[PFX-186] - jest refactor @gasket/plugin-nextjs (#535)

Author: mmason2-godaddy

package-lock.json

@@ -12,12 +12,10 @@
   "scripts": {
     "lint": "eslint .",
     "lint:fix": "npm run lint -- --fix",
-    "test": "npm run test:runner",
-    "test:runner": "mocha --require ./test/setup.js \"test/**/*.test.js\"",
-    "test:watch": "npm run test:runner -- --watch",
-    "test:coverage": "nyc --reporter=text --reporter=json-summary npm run test:runner",
-    "posttest": "npm run lint",
-    "report": "nyc report --reporter=lcov"
+    "test": "cross-env NODE_OPTIONS='--unhandled-rejections=strict' jest",
+    "test:watch": "jest --watch",
+    "test:coverage": "jest --coverage",
+    "posttest": "npm run lint"
   },
   "repository": {
     "type": "git",
@@ -51,25 +49,21 @@
     "@gasket/assets": "^6.36.1",
     "@gasket/engine": "^6.36.1",
     "@gasket/nextjs": "^6.37.0",
-    "assume": "^2.3.0",
-    "assume-sinon": "^1.1.0",
     "babel-eslint": "^10.1.0",
+    "cross-env": "^7.0.3",
     "eslint": "^8.7.0",
     "eslint-config-godaddy": "^6.0.0",
     "eslint-config-godaddy-react": "^8.0.0",
+    "eslint-plugin-jest": "^27.2.1",
     "eslint-plugin-json": "^3.1.0",
-    "eslint-plugin-mocha": "^10.0.3",
     "eslint-plugin-unicorn": "^44.0.0",
+    "jest": "^29.3.1",
     "lodash.merge": "^4.6.0",
-    "mocha": "^10.0.0",
     "next": "^12.0.8",
     "next-redux-wrapper": "^8.0.0",
-    "nyc": "^15.1.0",
     "prop-types": "^15.7.2",
-    "proxyquire": "^2.1.3",
     "react": "^18.0.0",
-    "react-dom": "^18.0.0",
-    "sinon": "^14.0.0"
+    "react-dom": "^18.0.0"
   },
   "peerDependencies": {
     "next": ">=10.2.0 < 13",
@@ -78,7 +72,8 @@
   },
   "eslintConfig": {
     "extends": [
-      "godaddy"
+      "godaddy",
+      "plugin:jest/recommended"
     ],
     "globals": {
       "expect": "readonly"
@@ -109,5 +104,8 @@
     "presets": [
       "@babel/preset-react"
     ]
+  },
+  "jest": {
+    "rootDir": "test"
   }
 }

packages/gasket-plugin-nextjs/package.json

@@ -1,5 +1,3 @@
-const assume = require('assume');
-const { spy } = require('sinon');
 const apmTransaction = require('../lib/apm-transaction');
 
 describe('The apmTransaction hook', () => {
@@ -8,7 +6,7 @@ describe('The apmTransaction hook', () => {
   beforeEach(() => {
     transaction = {
       name: 'GET *',
-      addLabels: spy()
+      addLabels: jest.fn()
     };
   });
 
@@ -18,7 +16,7 @@ describe('The apmTransaction hook', () => {
 
     await apmTransaction({}, transaction, { req });
 
-    assume(transaction.name).equals('GET /proxy/foo');
+    expect(transaction.name).toEqual('GET /proxy/foo');
   });
 
   it('returns the page name if the route is for a page', async () => {
@@ -31,15 +29,15 @@ describe('The apmTransaction hook', () => {
 
     await apmTransaction({}, transaction, { req });
 
-    assume(transaction.name).equals('/customer/[id]');
+    expect(transaction.name).toEqual('/customer/[id]');
   });
 
   it('does not set labels if the route is not for a page', async () => {
     const req = { getNextRoute: async () => null };
 
     await apmTransaction({}, transaction, { req });
 
-    assume(transaction.addLabels).was.not.called();
+    expect(transaction.addLabels).not.toHaveBeenCalled();
   });
 
   it('sets dynamic route params as labels if the route is for a page', async () => {
@@ -53,6 +51,6 @@ describe('The apmTransaction hook', () => {
 
     await apmTransaction({}, transaction, { req });
 
-    assume(transaction.addLabels).was.calledWith({ cohortId: 'Rad People' });
+    expect(transaction.addLabels).toHaveBeenCalledWith({ cohortId: 'Rad People' });
   });
 });