Skip to content

Commit 767ea86

Browse files
refactor(cdn): remove ACL parameter from S3 uploads, rely on bucket policy instead (#153)
1 parent 62a09a6 commit 767ea86

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
44

5+
- Remove ACL parameter from S3 uploads, rely on bucket policy for public access.
6+
57
## [7.4.2](https://github.com/godaddy/warehouse.ai/compare/7.4.0...7.4.2) (2025-10-29)
68

79
### Bug Fixes

lib/plugins/cdn.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ const finger = require('fingerprinting');
2222
* @property {WrhsAssetFile[]} files
2323
*/
2424

25-
const DEFAULT_ACL = 'public-read';
26-
2725
module.exports = fp(
2826
/**
2927
* Initialize CDN plugin
@@ -139,7 +137,6 @@ module.exports = fp(
139137
ContentType: mime.lookup(filepath),
140138
Bucket: cdnS3Bucket,
141139
Key: filepath,
142-
ACL: DEFAULT_ACL,
143140
Expires: expiration
144141
})
145142
.promise();

0 commit comments

Comments
 (0)