119 ISemanticPluginCompatible (#120)

* removed virtual, renamed to match content

* Semantic Kernel discoverability via ISemanticPluginCompatible

Author: goodtocode

src/Core.Application/Abstractions/IAuthorsPlugin.cs

@@ -1,6 +1,7 @@
 namespace Goodtocode.SemanticKernel.Core.Application.Abstractions;
 
-public interface IAuthorsPlugin
+public interface IAuthorsPlugin : ISemanticPluginCompatible
 {
-    Task<IAuthorResponse> GetAuthorNameAsync(Guid authorId, CancellationToken cancellationToken);
+    Task<IAuthorResponse> GetAuthorByIdAsync(Guid authorId, CancellationToken cancellationToken);
+    Task<ICollection<IAuthorResponse>> GetAuthorsByNameAsync(string name, CancellationToken cancellationToken);
 }

src/Core.Application/Abstractions/IChatMessagesPlugin.cs

@@ -1,6 +1,6 @@
 namespace Goodtocode.SemanticKernel.Core.Application.Abstractions;
 
-public interface IChatMessagesPlugin
+public interface IChatMessagesPlugin : ISemanticPluginCompatible
 {
     Task<IEnumerable<string>> ListRecentMessagesAsync(DateTime? startDate, DateTime? endDate, CancellationToken cancellationToken);
     Task<IEnumerable<string>> GetChatMessagesAsync(Guid sessionId, CancellationToken cancellationToken);

src/Core.Application/Abstractions/IChatSessionsPlugin.cs

@@ -1,6 +1,6 @@
 namespace Goodtocode.SemanticKernel.Core.Application.Abstractions;
 
-public interface IChatSessionsPlugin
+public interface IChatSessionsPlugin : ISemanticPluginCompatible
 {
     Task<IEnumerable<string>> ListRecentSessionsAsync(DateTime? startDate, DateTime? endDate, CancellationToken cancellationToken);
     Task<string> UpdateChatSessionTitleAsync(Guid sessionId, string newTitle, CancellationToken cancellationToken);

src/Core.Application/Abstractions/ISemanticPluginCompatible.cs

@@ -0,0 +1,9 @@
+namespace Goodtocode.SemanticKernel.Core.Application.Abstractions;
+
+public interface ISemanticPluginCompatible
+{
+    string PluginName { get; }
+    string FunctionName { get; }
+    Dictionary<string, object> Parameters { get; }
+
+}

src/Core.Application/ChatCompletion/ChatSessionDto.cs

@@ -8,7 +8,7 @@ public class ChatSessionDto
     public string Title { get; set; } = string.Empty;
     public Guid AuthorId { get; set; } = Guid.Empty;
     public DateTimeOffset Timestamp { get; set; }
-    public virtual ICollection<ChatMessageDto>? Messages { get; set; }
+    public ICollection<ChatMessageDto>? Messages { get; set; }
 
     public static ChatSessionDto CreateFrom(ChatSessionEntity? entity)
     {

src/Core.Application/TextGeneration/TextPromptDto.cs

@@ -9,7 +9,7 @@ public class TextPromptDto
     public Guid AuthorId { get; set; } = Guid.Empty;
     public string Prompt { get; set; } = string.Empty;
     public DateTimeOffset Timestamp { get; set; }
-    public virtual ICollection<TextResponseDto>? Responses { get; set; }
+    public ICollection<TextResponseDto>? Responses { get; set; }
 
     public static TextPromptDto CreateFrom(TextPromptEntity? entity)
     {

src/Core.Domain/ChatCompletion/ChatCompletionRoles.cs renamed to src/Core.Domain/ChatCompletion/ChatMessageRole.cs

@@ -1,4 +1,5 @@
 using Goodtocode.SemanticKernel.Core.Application.Abstractions;
+using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.SemanticKernel;
 using System.ComponentModel;
@@ -13,14 +14,28 @@ public class AuthorResponse : IAuthorResponse
     public string? Message { get; set; }
 }
 
+
 public sealed class AuthorsPlugin(IServiceProvider serviceProvider) : IAuthorsPlugin
 {
     private readonly IServiceProvider _serviceProvider = serviceProvider;
 
-    [KernelFunction("get_author")]
-    [Description("Returns structured author info including name, status, and explanation.")]
-    async Task<IAuthorResponse> IAuthorsPlugin.GetAuthorNameAsync(Guid authorId, CancellationToken cancellationToken)
+    public string PluginName => "AuthorsPlugin";
+    public string FunctionName => _currentFunctionName;
+    public Dictionary<string, object> Parameters => _currentParameters;
+
+    private string _currentFunctionName = string.Empty;
+    private Dictionary<string, object> _currentParameters = new();
+
+    [KernelFunction("get_author_by_id")]
+    [Description("Returns structured author info by ID including name, status, and explanation.")]
+    public async Task<IAuthorResponse> GetAuthorByIdAsync(Guid authorId, CancellationToken cancellationToken)
     {
+        _currentFunctionName = "get_author_by_id";
+        _currentParameters = new()
+        {
+            { "authorId", authorId }
+        };
+
         using var scope = _serviceProvider.CreateScope();
         var context = scope.ServiceProvider.GetRequiredService<ISemanticKernelContext>();
         var author = await context.Authors.FindAsync([authorId, cancellationToken], cancellationToken: cancellationToken);
@@ -46,4 +61,44 @@ async Task<IAuthorResponse> IAuthorsPlugin.GetAuthorNameAsync(Guid authorId, Can
                 : "Author found."
         };
     }
+
+    [KernelFunction("get_authors_by_name")]
+    [Description("Returns structured author info by name including ID, status, and explanation.")]
+    public async Task<ICollection<IAuthorResponse>> GetAuthorsByNameAsync(string name, CancellationToken cancellationToken)
+    {
+        _currentFunctionName = "get_authors_by_name";
+        _currentParameters = new()
+        {
+            { "name", name }
+        };
+
+        using var scope = _serviceProvider.CreateScope();
+        var context = scope.ServiceProvider.GetRequiredService<ISemanticKernelContext>();
+        var authors = await context.Authors
+            .Where(x => x.Name != null && EF.Functions.Like(x.Name, $"%{name}%"))
+            .ToListAsync(cancellationToken);
+
+        if (authors.Count == 0)
+        {
+            return [ new AuthorResponse
+            {
+                AuthorId = Guid.Empty,
+                Name = name,
+                Status = "NotFound",
+                Message = "No author found with the specified name."
+            } ];
+        }
+        else
+        {
+            return [.. authors.Select(a => new AuthorResponse
+            {
+                AuthorId = a.Id,
+                Name = a.Name,
+                Status = string.IsNullOrWhiteSpace(a.Name) ? "Partial" : "Found",
+                Message = string.IsNullOrWhiteSpace(a.Name)
+                    ? "Author exists but name is not yet linked to Entra External ID."
+                    : "Author found."
+            })];
+        }
+    }
 }

src/Infrastructure.SemanticKernel/Plugins/AuthorsPlugin.cs

@@ -6,30 +6,38 @@
 
 namespace Goodtocode.SemanticKernel.Infrastructure.SemanticKernel.Plugins;
 
-public sealed class ChatMessagesPlugin(IServiceProvider serviceProvider) : IChatMessagesPlugin
+public sealed class ChatMessagesPlugin(IServiceProvider serviceProvider)
+    : IChatMessagesPlugin, ISemanticPluginCompatible
 {
     private readonly IServiceProvider _serviceProvider = serviceProvider;
 
+    public string PluginName => "ChatMessagesPlugin";
+    public string FunctionName => _currentFunctionName;
+    public Dictionary<string, object> Parameters => _currentParameters;
+
+    private string _currentFunctionName = string.Empty;
+    private Dictionary<string, object> _currentParameters = [];
+
     [KernelFunction("list_messages")]
-    [Description("Retrieves the most recent messages from all chat sessions, optionally filtered by a start and/or end date. Results are ordered from newest to oldest.")]
+    [Description("Retrieves the most recent messages from all chat sessions.")]
     public async Task<IEnumerable<string>> ListRecentMessagesAsync(DateTime? startDate = null, DateTime? endDate = null,
         CancellationToken cancellationToken = default)
     {
-        // Resolve ISemanticKernelContext from a new scope to ensure correct EF Core lifetime management.
+        _currentFunctionName = "list_messages";
+        _currentParameters = new()
+    {
+        { "startDate", startDate ?? DateTime.UtcNow.AddDays(-7) },
+        { "endDate", endDate  ?? DateTime.UtcNow.AddSeconds(1)}
+    };
+
         using var scope = _serviceProvider.CreateScope();
         var context = scope.ServiceProvider.GetRequiredService<ISemanticKernelContext>();
 
         var query = context.ChatMessages.AsQueryable();
+        if (startDate.HasValue) query = query.Where(x => x.Timestamp >= startDate.Value);
+        if (endDate.HasValue) query = query.Where(x => x.Timestamp <= endDate.Value);
 
-        if (startDate.HasValue)
-            query = query.Where(x => x.Timestamp >= startDate.Value);
-        if (endDate.HasValue)
-            query = query.Where(x => x.Timestamp <= endDate.Value);
-
-        var messages = await query
-            .OrderByDescending(x => x.Timestamp)
-            .ToListAsync(cancellationToken);
-
+        var messages = await query.OrderByDescending(x => x.Timestamp).ToListAsync(cancellationToken);
         return messages.Select(m => $"{m.ChatSessionId}: {m.Timestamp:u} - {m.Role}: {m.Content}");
     }
 
@@ -38,14 +46,19 @@ public async Task<IEnumerable<string>> ListRecentMessagesAsync(DateTime? startDa
     public async Task<IEnumerable<string>> GetChatMessagesAsync(Guid sessionId,
         CancellationToken cancellationToken = default)
     {
-        // Get ISemanticKernelContext directly instead of constructor DI to allow this plugin to be registered via AddSingleton() and not scoped due to EF.
+        _currentFunctionName = "get_messages";
+        _currentParameters = new()
+    {
+        { "sessionId", sessionId }
+    };
+
         using var scope = _serviceProvider.CreateScope();
         var context = scope.ServiceProvider.GetRequiredService<ISemanticKernelContext>();
 
         var messages = await context.ChatMessages
-        .Where(x => x.ChatSessionId == sessionId)
+            .Where(x => x.ChatSessionId == sessionId)
             .ToListAsync(cancellationToken);
 
-        return messages.Select(m => $"{m.ChatSessionId}: {m.Timestamp} - {m.Role}: {m.Content}");
+        return messages.Select(m => $"{m.ChatSessionId}: {m.Timestamp:u} - {m.Role}: {m.Content}");
     }
-}
+}

src/Infrastructure.SemanticKernel/Plugins/ChatMessagesPlugin.cs

@@ -6,18 +6,35 @@
 
 namespace Goodtocode.SemanticKernel.Infrastructure.SemanticKernel.Plugins;
 
-public sealed class ChatSessionsPlugin(IServiceProvider serviceProvider) : IChatSessionsPlugin
+public interface ISemanticPluginCompatible
+{
+    string PluginName { get; }
+    string FunctionName { get; }
+    Dictionary<string, object> Parameters { get; }
+}
+
+public sealed class ChatSessionsPlugin(IServiceProvider serviceProvider) : IChatSessionsPlugin, ISemanticPluginCompatible
 {
     private readonly IServiceProvider _serviceProvider = serviceProvider;
 
+    public string PluginName => "ChatSessionsPlugin";
+    public string FunctionName => _currentFunctionName;
+    public Dictionary<string, object> Parameters => _currentParameters;
+
+    private string _currentFunctionName = string.Empty;
+    private Dictionary<string, object> _currentParameters = new();
+
     [KernelFunction("list_sessions")]
     [Description("Retrieves a list of recent chat sessions. Optionally, filter results by start and/or end date to narrow the search.")]
-    public async Task<IEnumerable<string>> ListRecentSessionsAsync(
-        DateTime? startDate = null,
-        DateTime? endDate = null,
-        CancellationToken cancellationToken = default)
+    public async Task<IEnumerable<string>> ListRecentSessionsAsync(DateTime? startDate = null, DateTime? endDate = null, CancellationToken cancellationToken = default)
     {
-        // Get ISemanticKernelContext directly instead of constructor DI to allow this plugin to be registered via AddSingleton() and not scoped due to EF.
+        _currentFunctionName = "list_sessions";
+        _currentParameters = new()
+        {
+            { "startDate", startDate ?? DateTime.UtcNow.AddDays(-7) },
+            { "endDate", endDate ?? DateTime.UtcNow.AddSeconds(1)}
+        };
+
         using var scope = _serviceProvider.CreateScope();
         var context = scope.ServiceProvider.GetRequiredService<ISemanticKernelContext>();
 
@@ -37,19 +54,30 @@ public async Task<IEnumerable<string>> ListRecentSessionsAsync(
 
     [KernelFunction("change_title")]
     [Description("Changes the title on this chat session.")]
-    public async Task<string> UpdateChatSessionTitleAsync(Guid sessionId, string newTitle,
-        CancellationToken cancellationToken = default)
+    public async Task<string> UpdateChatSessionTitleAsync(Guid sessionId, string newTitle, CancellationToken cancellationToken = default)
     {
-        // Get ISemanticKernelContext directly instead of constructor DI to allow this plugin to be registered via AddSingleton() and not scoped due to EF.
+        _currentFunctionName = "change_title";
+        _currentParameters = new()
+        {
+            { "sessionId", sessionId },
+            { "newTitle", newTitle }
+        };
+
         using var scope = _serviceProvider.CreateScope();
         var context = scope.ServiceProvider.GetRequiredService<ISemanticKernelContext>();
 
         var chatSession = await context.ChatSessions
             .FirstOrDefaultAsync(x => x.Id == sessionId, cancellationToken: cancellationToken);
-        chatSession!.Title = newTitle;
+
+        if (chatSession == null)
+        {
+            return $"Session {sessionId} not found.";
+        }
+
+        chatSession.Title = newTitle;
         context.ChatSessions.Update(chatSession);
         await context.SaveChangesAsync(cancellationToken);
 
         return $"{chatSession.Id}: {chatSession.Timestamp} - {chatSession.Title}: {chatSession.Author?.Name}";
     }
-}
+}