-
Notifications
You must be signed in to change notification settings - Fork 9.5k
Add User email detail to about box #13459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ptone, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new feature to display the authenticated user's email address within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the user's email to the about box when they are authenticated via Google login. The changes are well-structured, touching the necessary files from the core package to the UI components. My review focuses on improving the test coverage for this new feature. I've provided a suggestion to make the mock for UserAccountManager more flexible, which will enable testing the scenario where a user is not logged in and no email should be displayed. This will help ensure the feature is robust and behaves as expected in all cases.
Summary
If the user is authenticated with Google login, the /about box now displays the email of the logged in user

Details
packages/core/src/index.ts: Exported UserAccountManager so it can be used by the CLI.packages/cli/src/ui/types.ts: Updated HistoryItemAbout and Message types to include the optional userEmail field.packages/cli/src/ui/commands/aboutCommand.ts: Modified the about command to instantiate UserAccountManager, retrieve the cached user email, and include itin the aboutItem.
packages/cli/src/ui/components/AboutBox.tsx: Updated the AboutBox component to conditionally render the "User Email" row if an email address is present.packages/cli/src/ui/commands/aboutCommand.test.ts: Updated unit tests to mock UserAccountManager and verify that the user email is correctly passed to theUI.
Related Issues
fixes #13458
How to Validate
login with different auth methods and ensure email is shown when, and only when logged in via oauth
Pre-Merge Checklist