Skip to content

Conversation

@annasba07
Copy link

Summary

Replace the static '⠏' character with an animated spinner during the "Waiting for user confirmation" state. This provides better visual feedback that the CLI is still active and awaiting input.

Changes

  • GeminiRespondingSpinner.tsx: Updated to show animated spinner for both Responding and WaitingForConfirmation states
  • LoadingIndicator.tsx: Removed static '⠏' fallback since spinner now handles confirmation state
  • LoadingIndicator.test.tsx: Updated mock and test assertions to reflect new animated behavior

Test plan

  • All LoadingIndicator tests pass (16/16)
  • Pre-commit hooks pass (eslint, prettier)
  • Visual behavior: Spinner now animates during confirmation prompts instead of showing static character

Before/After

Before: Static '⠏' character during confirmation (no visual indication CLI is active)
After: Animated dots spinner during confirmation (consistent with Responding state)

Fixes #13395

Replace the static '⠏' character with an animated spinner during the
"Waiting for user confirmation" state. This provides better visual
feedback that the CLI is still active and awaiting input.

Changes:
- Update GeminiRespondingSpinner to show animated spinner for both
  Responding and WaitingForConfirmation states
- Remove static fallback from LoadingIndicator
- Update tests to reflect new behavior

Fixes google-gemini#13395
@annasba07 annasba07 requested a review from a team as a code owner November 20, 2025 01:43
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @annasba07, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user experience of the CLI by introducing an animated spinner during the "Waiting for user confirmation" state. This change ensures that users receive continuous visual feedback, making the application feel more responsive and active rather than appearing frozen while awaiting input.

Highlights

  • Animated Spinner for Confirmation: Replaced the static '⠏' character with an animated spinner for the "Waiting for user confirmation" state in the CLI.
  • Improved Visual Feedback: Provides better visual feedback to users, indicating that the CLI is active and awaiting input.
  • Component Logic Update: Modified GeminiRespondingSpinner.tsx to activate the animated spinner for both Responding and WaitingForConfirmation streaming states.
  • Code Simplification: Removed the static character fallback from LoadingIndicator.tsx as the spinner now handles the confirmation state directly.
  • Test Updates: Updated LoadingIndicator.test.tsx to reflect the new animated behavior and ensure test coverage.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the user experience by replacing a static character with an animated spinner during the 'Waiting for user confirmation' state. The changes are well-contained and correctly implemented across the GeminiRespondingSpinner, LoadingIndicator, and related test files. The code is cleaner as a result of moving state-dependent rendering logic into the GeminiRespondingSpinner component. I have one suggestion regarding accessibility for screen reader users, which I've detailed in a specific comment.

Comment on lines 33 to 36
if (
streamingState === StreamingState.Responding ||
streamingState === StreamingState.WaitingForConfirmation
) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The altText for the spinner is hardcoded to SCREEN_READER_RESPONDING. While this is correct for the Responding state, it's misleading for screen reader users when the state is WaitingForConfirmation. The accessible text should reflect that the CLI is waiting for user input, not generating a response. Please consider using a different altText for the WaitingForConfirmation state to improve accessibility.

@annasba07 annasba07 marked this pull request as draft November 20, 2025 01:51
Address accessibility feedback: use distinct alt text for screen readers
when in WaitingForConfirmation state vs Responding state.

- Add SCREEN_READER_WAITING_FOR_CONFIRMATION constant
- Update GeminiRespondingSpinner to use state-appropriate alt text
@annasba07 annasba07 marked this pull request as ready for review November 24, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Animated Spinner for “Waiting for user confirmation” State in CLI

1 participant