-
Notifications
You must be signed in to change notification settings - Fork 9.7k
feat(cli): add animated spinner for WaitingForConfirmation state #13465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(cli): add animated spinner for WaitingForConfirmation state #13465
Conversation
Replace the static '⠏' character with an animated spinner during the "Waiting for user confirmation" state. This provides better visual feedback that the CLI is still active and awaiting input. Changes: - Update GeminiRespondingSpinner to show animated spinner for both Responding and WaitingForConfirmation states - Remove static fallback from LoadingIndicator - Update tests to reflect new behavior Fixes google-gemini#13395
Summary of ChangesHello @annasba07, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience of the CLI by introducing an animated spinner during the "Waiting for user confirmation" state. This change ensures that users receive continuous visual feedback, making the application feel more responsive and active rather than appearing frozen while awaiting input. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request improves the user experience by replacing a static character with an animated spinner during the 'Waiting for user confirmation' state. The changes are well-contained and correctly implemented across the GeminiRespondingSpinner, LoadingIndicator, and related test files. The code is cleaner as a result of moving state-dependent rendering logic into the GeminiRespondingSpinner component. I have one suggestion regarding accessibility for screen reader users, which I've detailed in a specific comment.
| if ( | ||
| streamingState === StreamingState.Responding || | ||
| streamingState === StreamingState.WaitingForConfirmation | ||
| ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The altText for the spinner is hardcoded to SCREEN_READER_RESPONDING. While this is correct for the Responding state, it's misleading for screen reader users when the state is WaitingForConfirmation. The accessible text should reflect that the CLI is waiting for user input, not generating a response. Please consider using a different altText for the WaitingForConfirmation state to improve accessibility.
Address accessibility feedback: use distinct alt text for screen readers when in WaitingForConfirmation state vs Responding state. - Add SCREEN_READER_WAITING_FOR_CONFIRMATION constant - Update GeminiRespondingSpinner to use state-appropriate alt text
Summary
Replace the static '⠏' character with an animated spinner during the "Waiting for user confirmation" state. This provides better visual feedback that the CLI is still active and awaiting input.
Changes
RespondingandWaitingForConfirmationstatesTest plan
Before/After
Before: Static '⠏' character during confirmation (no visual indication CLI is active)
After: Animated dots spinner during confirmation (consistent with Responding state)
Fixes #13395