-
Notifications
You must be signed in to change notification settings - Fork 9.9k
chore: fix session browser test and skip hook system tests #14099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @jackwotherspoon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a flakiness issue in a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a flaky test in SessionBrowser.test.tsx that was caused by using the real system time for relative date calculations. The fix correctly implements vitest's fake timers by setting a fixed time in beforeEach and restoring real timers in afterEach. This is an excellent change that ensures test determinism and prevents future failures due to the passage of time. The implementation is correct and improves the reliability of the test suite.
|
Size Change: -2 B (0%) Total Size: 21.4 MB ℹ️ View Unchanged
|
|
/patch preview |
|
✅ Patch workflow(s) dispatched successfully! 📋 Details:
🔗 Track Progress: |
# Conflicts: # integration-tests/hooks-system.test.ts
|
🚀 Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 Patch Release Started! 📋 Release Details:
⏳ Status: The patch release is now running. You'll receive another update when it completes. 🔗 Track Progress: |
|
✅ Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
Summary
Session Browser Test
One of the Session Browser tests uses the current time relative to Jan 2025 for testing.
So a test that was looking for a session age of
10mnow expects11mbecause test uses current date.Updating test to use fake system time so that tests always pass and don't need to be updated each month 👍
Hook System Tests
A few of the hook system tests added in #9112 do not work on Windows because they use bash scripts and the hook runner uses
shell: true, which uses cmd.exe/PowerShell on Windows, not bash.Skipping them for now, will let @Edilmo see about adding them back.