PUBLIC: Discourage static importing values().

PiperOrigin-RevId: 833969838

Author: kluever

core/src/main/java/com/google/errorprone/bugpatterns/BadImport.java

@@ -87,16 +87,20 @@ public class BadImport extends BugChecker implements ImportTreeMatcher {
 
   private static final ImmutableSet<String> BAD_STATIC_IDENTIFIERS =
       ImmutableSet.of(
+          // keep-sorted start
+          "INSTANCE",
           "builder",
-          "create",
           "copyOf",
+          "create",
           "from",
           "getDefaultInstance",
-          "INSTANCE",
           "newBuilder",
           "newInstance",
           "of",
-          "valueOf");
+          "valueOf",
+          "values"
+          // keep-sorted end
+          );
 
   private static final MultiMatcher<Tree, AnnotationTree> HAS_TYPE_USE_ANNOTATION =
       annotations(AT_LEAST_ONE, (t, state) -> isTypeAnnotation(t));

core/src/test/java/com/google/errorprone/bugpatterns/BadImportTest.java

@@ -731,6 +731,26 @@ class Test {
         .doTest();
   }
 
+  @Test
+  public void enumValues() {
+    compilationTestHelper
+        .addSourceLines(
+            "Test.java",
+            """
+            import static java.util.concurrent.TimeUnit.values;
+
+            import java.util.concurrent.TimeUnit;
+
+            class Test {
+              void foo() {
+                // BUG: Diagnostic contains: TimeUnit.values()
+                TimeUnit[] timeUnits = values();
+              }
+            }
+            """)
+        .doTest();
+  }
+
   @Test
   public void doesNotMatchProtos() {
     compilationTestHelper