Skip to content

Commit 5b9efc1

Browse files
committed
fix ci failures
1 parent cb03918 commit 5b9efc1

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

ci/cloudbuild/builds/lib/integration.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ source module ci/lib/io.sh
3131
export PATH="${HOME}/.local/bin:${PATH}"
3232
python3 -m pip uninstall -y --quiet googleapis-storage-testbench
3333
python3 -m pip install --upgrade --user --quiet --disable-pip-version-check \
34-
"git+https://github.com/googleapis/storage-testbench@v0.56.0"
34+
"git+https://github.com/googleapis/storage-testbench@v0.58.0"
3535

3636
# Some of the tests will need a valid roots.pem file.
3737
rm -f /dev/shm/roots.pem

google/cloud/storage/google_cloud_cpp_storage.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,8 @@ google_cloud_cpp_storage_hdrs = [
116116
"internal/unified_rest_credentials.h",
117117
"internal/well_known_parameters_impl.h",
118118
"lifecycle_rule.h",
119-
"list_buckets_reader.h",
120119
"list_buckets_partial_reader.h",
120+
"list_buckets_reader.h",
121121
"list_hmac_keys_reader.h",
122122
"list_objects_and_prefixes_reader.h",
123123
"list_objects_reader.h",

google/cloud/storage/internal/bucket_requests_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ TEST(ListBucketsRequestTest, PartialSuccess) {
141141
std::ostringstream os;
142142
os << request;
143143
EXPECT_THAT(os.str(), HasSubstr("ListBucketsRequest"));
144-
EXPECT_THAT(os.str(), HasSubstr("returnPartialSuccess=1"));
144+
EXPECT_THAT(os.str(), HasSubstr("returnPartialSuccess=true"));
145145
}
146146

147147
TEST(ListBucketsResponseTest, Parse) {

google/cloud/storage/internal/grpc/bucket_request_parser_test.cc

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ TEST(GrpcBucketRequestParser, ListBucketsRequestAllOptions) {
187187
page_size: 123
188188
page_token: "test-token"
189189
prefix: "test-prefix"
190-
return_partial_success: "true"
190+
return_partial_success: false
191191
read_mask { paths: [ "*" ] }
192192
)pb",
193193
&expected));
@@ -216,8 +216,6 @@ TEST(GrpcBucketRequestParser, ListBucketsResponse) {
216216
name: "projects/_/buckets/test-bucket-2"
217217
bucket_id: "test-bucket-2"
218218
}
219-
unreachable { "projects/_/buckets/bucket1"
220-
"projects/_/buckets/bucket2" }
221219
next_page_token: "test-token"
222220
)pb",
223221
&input));

0 commit comments

Comments
 (0)