Added toJson to DataSnapshot and Query (#119)

Author: kevmoo

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 4.1.0
+
+* Added `toJson` to `DataSnapshot` and `Query`. 
+
 ## 4.0.0
 
 * Upgraded to Firebase JS API `4.1.3`.

lib/src/auth.dart

@@ -177,6 +177,7 @@ class User extends UserInfo<firebase_interop.UserJsImpl> {
   Future updateProfile(firebase_interop.UserProfile profile) =>
       handleThenable(jsObject.updateProfile(profile));
 
+  /// Returns a JSON-serializable representation of this object.
   Map<String, dynamic> toJson() => dartify(jsObject.toJSON());
 
   @override

lib/src/database.dart

@@ -350,6 +350,9 @@ class Query<T extends database_interop.QueryJsImpl> extends JsObjectWrapper<T> {
   /// Returns a String representation of Query object.
   @override
   String toString() => jsObject.toString();
+
+  /// Returns a JSON-serializable representation of this object.
+  dynamic toJson() => dartify(jsObject.toJSON());
 }
 
 /// A DataSnapshot contains data from a database location.
@@ -406,6 +409,9 @@ class DataSnapshot
 
   /// Returns Dart value from a DataSnapshot.
   dynamic val() => dartify(jsObject.val());
+
+  /// Returns a JSON-serializable representation of this object.
+  dynamic toJson() => dartify(jsObject.toJSON());
 }
 
 /// The OnDisconnect class allows you to write or clear data when your client

lib/src/interop/database_interop.dart

@@ -71,6 +71,7 @@ abstract class QueryJsImpl {
   external QueryJsImpl startAt(value, [String key]);
   @override
   external String toString();
+  external Object toJSON();
 }
 
 @JS('DataSnapshot')
@@ -88,6 +89,7 @@ abstract class DataSnapshotJsImpl {
   external bool hasChildren();
   external int numChildren();
   external dynamic val();
+  external Object toJSON();
 }
 
 @JS('OnDisconnect')

pubspec.yaml

@@ -1,6 +1,6 @@
 name: firebase
 description: Dart libraries for Firebase
-version: 4.0.0
+version: 4.1.0-dev
 authors:
 - Jana Moudra <[email protected]>
 - Kevin Moore <[email protected]>

test/database_test.dart

@@ -64,25 +64,37 @@ void main() {
         key = null;
       });
 
+      test("has toJson", () {
+        var toJsonString = ref.toJson() as String;
+        expect(toJsonString, startsWith(databaseUrl));
+
+        var uri = Uri.parse(ref.toJson() as String);
+        expect(uri.pathSegments, hasLength(1));
+      });
+
       test("remove", () async {
         var eventFuture = ref.onValue.first;
 
         await ref.remove();
         var event = await eventFuture;
 
         expect(event.snapshot.val(), isNull);
+        expect(event.snapshot.toJson(), isNull);
       });
 
       test("child and once on value", () async {
         var childRef = ref.child(key);
+
         var event = await childRef.once("value");
         expect(event.snapshot.key, key);
         expect(event.snapshot.val()["text"], "hello");
+        expect(event.snapshot.toJson(), {'text': 'hello'});
 
         childRef = childRef.child("text");
         event = await childRef.once("value");
         expect(event.snapshot.key, "text");
         expect(event.snapshot.val(), "hello");
+        expect(event.snapshot.toJson(), 'hello');
       });
 
       test("key", () {