Skip to content

Conversation

@matrei
Copy link
Contributor

@matrei matrei commented Oct 12, 2025

  • Updated for Grails 7
  • Changed from ExpandoMetaClass to Extension Modules
  • New coords: io.github.gpc:grails-postgresql-extensions
  • Re-packaged to gpc.pgext.*
  • Re-organized project

- Updated for Grails 7
- Changed from ExpandoMetaClass to Extension Modules
- New coords: `org.grails.plugins:grails-postgresql-extensions`
- Re-packaged to `gpc.pgext.*`
- Re-organized project
@matrei matrei requested a review from sbglasius October 12, 2025 12:40
GPC projects should publish to `io.github.gpc`.
@@ -1,16 +1,16 @@
package net.kaleidos.hibernate.criterion.array
package gpc.pgext.hibernate.criterion.array
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

Comment on lines +25 to +27
}

PgHstoreOperatorExpression(String propertyName, Map<Object, String> value, String operator) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could these two constructors just be joined into one:

PgHstoreOperatorExpression(String propertyName, Object value, String operator) {
     this.propertyName = propertyName
      this.value = value as Map<Object, String>
      this.operator = operator
}

static Object[] getValueAsArrayOfType(Object targetValue, Class<?> expectedType, MapFunction mapFunction) {
Object[] arrValue
static Object[] getValueAsArrayOfType(Object targetValue, Class expectedType, MapFunction mapFunction) {
if (targetValue instanceof Object[]) return (Object[]) targetValue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add curly brackets like if() {}

def items = (targetValue instanceof Collection) ? (targetValue as List) : [targetValue]
def converted = items.collect { o ->
if (expectedType.isInstance(o)) return o
if (mapFunction) return mapFunction.map(o)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return in curly brackets

@sbglasius sbglasius merged commit 9527d51 into 8.x Oct 16, 2025
3 checks passed
@sbglasius sbglasius deleted the grails7 branch October 16, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants