Add unit tests

Author: gpotter2

.github/check_spdx.sh

@@ -0,0 +1,36 @@
+#!/bin/bash
+
+# SPDX-License-Identifier: GPL-2.0-only
+# This file is part of Scapy RPC
+# See https://scapy.net/ for more information
+
+# Check that all Scapy RPC files have a SPDX
+
+SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
+ROOT_DIR=$SCRIPT_DIR/..
+
+# http://mywiki.wooledge.org/BashFAQ/024
+# This documents an absolutely WTF behavior of bash.
+set +m
+shopt -s lastpipe
+
+function check_path() {
+    cd $ROOT_DIR
+    RCODE=0
+    for ext in "${@:2}"; do
+        find $1 -name "*.$ext" | while read f; do
+            if [[ "$f" == *"/ply/"* ]]; then
+                # Skip PLY
+                continue
+            fi
+            if [[ -z $(grep "SPDX" $f) ]]; then
+                echo "$f"
+                RCODE=1
+            fi
+        done
+    done
+    return $RCODE
+}
+
+check_path midl-to-scapy py || exit $?
+check_path scapy-rpc py || exit $?

.github/workflows/unittests.yml

@@ -0,0 +1,43 @@
+name: Scapy RPC unit tests
+
+on:
+  push:
+    branches: [master]
+  pull_request:
+    # The branches below must be a subset of the branches above
+    branches: [master]
+
+# https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{ !contains(github.ref, 'master')}}
+
+permissions:
+  contents: read
+
+jobs:
+  health:
+    name: Code health check
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Scapy-rpc
+        uses: actions/checkout@v4
+      - name: Setup Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.13"
+      - name: Check black compliance
+        uses: psf/black@stable
+        with:
+          src: "./scapy-rpc"
+          use_pyproject: true
+      - name: Run twine check
+        run: tox -e twine
+  spdx:
+    name: Check SPDX identifiers
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Scapy
+        uses: actions/checkout@v4
+      - name: Launch script
+        run: bash .github/check_spdx.sh

midl-to-scapy/idl/idl_scraper.py

@@ -42,7 +42,7 @@
         "extras": [
             # Protocols not listed in the "list"
             "ms-oxcrpc",
-        ]
+        ],
     },
     {
         "name": "SharePoint Protocols",

scapy-rpc/msrpcs/__init__.py

@@ -1,3 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0-only
+# This file is part of Scapy RPC
+# See https://scapy.net/ for more information
+
 """
 Scapy RPC definitions
 """
@@ -11,7 +15,7 @@
 
 def scapy_ext(plg):
     plg.config("Scapy RPC", __version__)
-    for lay in pathlib.Path(__file__).parent.glob('*.py'):
+    for lay in pathlib.Path(__file__).parent.glob("*.py"):
         if lay.name == "__init__.py":
             continue
         plg.register(