refactor(create-plugin): make additions self-contained with dynamic flag loading

- Each addition script now exports its own flags and parseFlags function
- Removed prompts.ts in favor of CLI flags
- Manager dynamically loads flags from addition scripts
- Simplified additions.ts to only contain metadata
- Makes adding new additions fully plug-and-play without touching core files

Author: sunker

packages/create-plugin/src/additions/additions.ts

@@ -4,10 +4,6 @@ export type AdditionMeta = {
   scriptPath: string;
 };
 
-type Additions = {
-  additions: Record<string, AdditionMeta>;
-};
-
 export default {
   additions: {
     i18n: {
@@ -16,4 +12,4 @@ export default {
       scriptPath: './scripts/add-i18n.js',
     },
   },
-} as Additions;
+};

packages/create-plugin/src/additions/manager.ts

@@ -26,6 +26,27 @@ export function getAdditionByName(
   return additions[name];
 }
 
+export async function getAdditionFlags(addition: AdditionMeta): Promise<any[]> {
+  try {
+    const module = await import(addition.scriptPath);
+    return module.flags || [];
+  } catch (error) {
+    return [];
+  }
+}
+
+export async function parseAdditionFlags(addition: AdditionMeta, argv: any): Promise<AdditionOptions> {
+  try {
+    const module = await import(addition.scriptPath);
+    if (module.parseFlags && typeof module.parseFlags === 'function') {
+      return module.parseFlags(argv);
+    }
+    return {};
+  } catch (error) {
+    return {};
+  }
+}
+
 export async function runAddition(
   addition: AdditionMeta,
   additionOptions: AdditionOptions = {},

packages/create-plugin/src/additions/scripts/add-i18n.ts

@@ -12,6 +12,22 @@ export type I18nOptions = {
   locales: string[];
 };
 
+// Flag schema for CLI
+export const flags = [
+  {
+    name: 'locales',
+    description: 'Comma-separated list of locales (e.g., en-US,es-ES)',
+    required: true,
+  },
+];
+
+// Parse CLI flags to options
+export function parseFlags(argv: any): I18nOptions {
+  return {
+    locales: argv.locales ? argv.locales.split(',').map((l: string) => l.trim()) : [],
+  };
+}
+
 export default function migrate(context: Context, options: I18nOptions = { locales: ['en-US'] }): Context {
   const { locales } = options;
 

packages/create-plugin/src/commands/add.command.ts

@@ -1,24 +1,41 @@
-import { getAdditionByName, getAvailableAdditions, runAddition } from '../additions/manager.js';
+import {
+  AdditionOptions,
+  getAdditionByName,
+  getAdditionFlags,
+  getAvailableAdditions,
+  parseAdditionFlags,
+  runAddition,
+} from '../additions/manager.js';
 import { isGitDirectory, isGitDirectoryClean } from '../utils/utils.git.js';
 
 import { isPluginDirectory } from '../utils/utils.plugin.js';
 import minimist from 'minimist';
 import { output } from '../utils/utils.console.js';
-import { promptI18nOptions } from './add/prompts.js';
 
 export const add = async (argv: minimist.ParsedArgs) => {
   const subCommand = argv._[1];
 
   if (!subCommand) {
     const availableAdditions = getAvailableAdditions();
-    const additionsList = Object.values(availableAdditions).map(
-      (addition) => `${addition.name} - ${addition.description}`
+    const additionsList = await Promise.all(
+      Object.values(availableAdditions).map(async (addition) => {
+        let info = `${addition.name} - ${addition.description}`;
+        const flags = await getAdditionFlags(addition);
+        if (flags.length > 0) {
+          const flagDocs = flags.map((flag) => {
+            const req = flag.required ? ' (required)' : ' (optional)';
+            return `  --${flag.name}: ${flag.description}${req}`;
+          });
+          info += '\n' + flagDocs.join('\n');
+        }
+        return info;
+      })
     );
 
     output.error({
       title: 'No addition specified',
       body: [
-        'Usage: npx @grafana/create-plugin add <addition-name>',
+        'Usage: npx @grafana/create-plugin add <addition-name> [options]',
         '',
         'Available additions:',
         ...output.bulletList(additionsList),
@@ -43,16 +60,11 @@ export const add = async (argv: minimist.ParsedArgs) => {
   }
 
   try {
-    // Gather options based on the addition type
-    let options = {};
-
-    switch (addition.name) {
-      case 'i18n':
-        options = await promptI18nOptions();
-        break;
-      default:
-        break;
-    }
+    // Parse addition-specific options from argv flags using the addition's own parser
+    const options = await parseAdditionFlags(addition, argv);
+
+    // Validate required flags
+    await validateAdditionOptions(addition, options);
 
     const commitChanges = argv.commit;
     await runAddition(addition, options, { commitChanges });
@@ -67,6 +79,43 @@ export const add = async (argv: minimist.ParsedArgs) => {
   }
 };
 
+async function validateAdditionOptions(addition: any, options: AdditionOptions): Promise<void> {
+  const flags = await getAdditionFlags(addition);
+
+  if (!flags || flags.length === 0) {
+    return;
+  }
+
+  const missingFlags: string[] = [];
+
+  for (const flag of flags) {
+    if (flag.required) {
+      const value = options[flag.name];
+      if (value === undefined || value === null || (Array.isArray(value) && value.length === 0)) {
+        missingFlags.push(flag.name);
+      }
+    }
+  }
+
+  if (missingFlags.length > 0) {
+    const flagDocs = flags
+      .filter((f: any) => missingFlags.includes(f.name))
+      .map((f: any) => `  --${f.name}: ${f.description}`);
+
+    output.error({
+      title: `Missing required flag${missingFlags.length > 1 ? 's' : ''}`,
+      body: [
+        `The following required flag${missingFlags.length > 1 ? 's are' : ' is'} missing:`,
+        '',
+        ...flagDocs,
+        '',
+        `Example: npx @grafana/create-plugin add ${addition.name} --${missingFlags[0]}=value`,
+      ],
+    });
+    process.exit(1);
+  }
+}
+
 async function performPreAddChecks(argv: minimist.ParsedArgs) {
   if (!(await isGitDirectory()) && !argv.force) {
     output.error({