naming

Author: Jakeii

ab-testing/cdk/bin/deployment-lambda.cdk.ts

@@ -1,18 +1,18 @@
 import "source-map-support/register.js";
 import { GuRoot } from "@guardian/cdk/lib/constructs/root.js";
-import { DeploymentLambda } from "../lib/deploymentLambda.ts";
+import { AbTestingDeploymentLambda } from "../lib/deploymentLambda.ts";
 
 const app = new GuRoot({ outdir: "cdk.out/deployment-lambda" });
 
-new DeploymentLambda(app, "AbTestingDeploymentLambdaCode", {
+new AbTestingDeploymentLambda(app, "AbTestingDeploymentLambdaCode", {
 	stack: "frontend",
 	stage: "CODE",
 	env: {
 		region: "eu-west-1",
 	},
 });
 
-new DeploymentLambda(app, "AbTestingDeploymentLambdaProd", {
+new AbTestingDeploymentLambda(app, "AbTestingDeploymentLambdaProd", {
 	stack: "frontend",
 	stage: "PROD",
 	env: {

ab-testing/cdk/lib/abTestingConfig.ts

@@ -3,6 +3,7 @@ import { GuStack } from "@guardian/cdk/lib/constructs/core/stack.js";
 import type { App } from "aws-cdk-lib";
 import { CustomResource, Duration } from "aws-cdk-lib";
 import { Function } from "aws-cdk-lib/aws-lambda";
+import { lambdaFunctionName } from "./deploymentLambda.ts";
 
 export class AbTestingConfig extends GuStack {
 	constructor(scope: App, id: string, props: GuStackProps) {
@@ -11,7 +12,7 @@ export class AbTestingConfig extends GuStack {
 		const lambda = Function.fromFunctionName(
 			this,
 			"DeploymentLambdaFunction",
-			`${props.app}-${this.stage}`,
+			`${lambdaFunctionName}-${this.stage}`,
 		);
 
 		// Trigger the Lambda to run upon deployment

ab-testing/cdk/lib/deploymentLambda.ts

@@ -6,7 +6,9 @@ import type { App } from "aws-cdk-lib";
 import { Runtime } from "aws-cdk-lib/aws-lambda";
 import { StringParameter } from "aws-cdk-lib/aws-ssm";
 
-export class DeploymentLambda extends GuStack {
+export const lambdaFunctionName = "ab-testing-deployment-lambda";
+
+export class AbTestingDeploymentLambda extends GuStack {
 	constructor(scope: App, id: string, props: GuStackProps) {
 		super(scope, id, props);
 
@@ -38,10 +40,10 @@ export class DeploymentLambda extends GuStack {
 			);
 
 		const lambda = new GuLambdaFunction(this, "AbTestingDeploymentLambda", {
-			functionName: `ab-testing-deployment-${this.stage}`,
+			functionName: `${lambdaFunctionName}-${this.stage}`,
 			fileName: "lambda.zip",
 			handler: "index.handler",
-			app: "ab-testing-deployment-lambda",
+			app: `${lambdaFunctionName}-lambda`,
 			runtime: Runtime.NODEJS_22_X,
 			memorySize: 256,
 			environment: {