Skip to content

Commit a124656

Browse files
committed
Add better videos to stories
1 parent 384995c commit a124656

File tree

2 files changed

+21
-8
lines changed

2 files changed

+21
-8
lines changed

dotcom-rendering/src/components/FeatureCard.stories.tsx

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,7 @@ export const WithSublinksLabsImmersive: Story = {
379379
},
380380
};
381381

382-
export const WithSelfHostedVideo: Story = {
382+
export const WithSelfHostedVideo = {
383383
args: {
384384
...cardProps,
385385
showVideo: true,
@@ -389,20 +389,31 @@ export const WithSelfHostedVideo: Story = {
389389
atomId: 'atom-id-123',
390390
sources: [
391391
{
392-
src: 'https://uploads.guim.co.uk/2025%2F06%2F20%2Ftesting+only%2C+please+ignore--3cb22b60-2c3f-48d6-8bce-38c956907cce-3.mp4',
392+
src: 'https://uploads.guim.co.uk/2025/11/27/4_5_Test--1d34df3e-8c92-4090-8bb6-d79fc7fb9467-1.0.mp4',
393393
mimeType: 'video/mp4',
394394
},
395395
],
396-
width: 900,
396+
width: 576,
397397
height: 720,
398398
duration: 18,
399399
},
400400
},
401-
};
401+
} satisfies Story;
402402

403-
export const WithSelfHostedImmersiveVideo: Story = {
403+
export const WithSelfHostedImmersiveVideo = {
404404
args: {
405405
...WithSelfHostedVideo.args,
406-
isImmersive: true,
406+
...Immersive.args,
407+
mainMedia: {
408+
...WithSelfHostedVideo.args.mainMedia,
409+
sources: [
410+
{
411+
src: 'https://uploads.guim.co.uk/2025/11/27/5_3_Test--26763e61-c16b-4c10-8c16-3f11882da154-1.0.mp4',
412+
mimeType: 'video/mp4',
413+
},
414+
],
415+
width: 1200,
416+
height: 720,
417+
},
407418
},
408-
};
419+
} satisfies Story;

dotcom-rendering/src/components/FeatureCard.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -535,7 +535,9 @@ export const FeatureCard = ({
535535
fallbackImageAlt={
536536
media.imageAltText
537537
}
538-
fallbackImageAspectRatio="5:4"
538+
fallbackImageAspectRatio={
539+
isImmersive ? '5:3' : '4:5'
540+
}
539541
linkTo={linkTo}
540542
subtitleSource={
541543
media.mainMedia.subtitleSource

0 commit comments

Comments
 (0)