-
Notifications
You must be signed in to change notification settings - Fork 30
Make interactives support dark mode across platforms after January 2026 #14749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dc5d364 to
64b02cb
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
64b02cb to
8218642
Compare
| hasLiveBlogTopAd: !!frontendData.config.hasLiveBlogTopAd, | ||
| hasSurveyAd: !!frontendData.config.hasSurveyAd, | ||
| onlyLightColourScheme: | ||
| design === ArticleDesign.FullPageInteractive || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick question(s) for my understanding: are full page interactives not currently built with dark mode support? And is that a current limitation of the platform, or is it just not a design consideration at the moment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SiAdcock. Sorry for the slow reply, there's been a back and forth going on about this. Interactive articles are built to support dark mode but at present only on apps. On the web light mode is currently forced (see #11982). This isn't a limitation of the platform - more to reduce complexity in an already complex dev progress. That said, now the DCAR migration is finished interactive articles are rendered in the same way across web and apps, so why not align dark mode expectations too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @frederickobrien. Yes, I wonder if aligning light and dark mode support across web and apps might reduce complexity, but I appreciate it's extra work, and dark mode is still in beta, so probably not a priority for teams working on DCAR at the moment.
I've started a doc to track our support of dark mode on the web while it is in beta. Maybe we can add things to it as they come up, so we get a better understanding of the effort it will take to finish this work.
edb9fda to
ee81a5f
Compare
ee81a5f to
d0db510
Compare
jonathonherbert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ronseal, as long as the conversation above does not block :)
This adjusts the check for forcing light mode only on interactive articles, adjusting it to only apply on pieces before the DCAR migration was completed.