Skip to content

Extend expiration of user benefits cookies to 30 days #14810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Extend expiration of user benefits cookies to 30 days #14810

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e544fc
Extend expiry of user benefits cookies to 30 days
tjmw Nov 7, 2025
933b667
Extract const
tjmw Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 37 additions & 5 deletions dotcom-rendering/src/client/userFeatures/user-features.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* https://github.com/guardian/commercial/blob/1a429d6be05657f20df4ca909df7d01a5c3d7402/src/lib/user-features.ts
*/

import { removeCookie } from '@guardian/libs';
import { getAuthStatus, isUserLoggedIn } from '../../lib/identity';
import { AD_FREE_USER_COOKIE } from './cookies/adFree';
import { ALLOW_REJECT_ALL_COOKIE } from './cookies/allowRejectAll';
Expand Down Expand Up @@ -36,6 +37,8 @@ const requestNewData = async () => {
return syncDataFromUserBenefitsApi(authStatus).then(persistResponse);
};

const USER_BENEFITS_COOKIE_EXPIRATION_IN_DAYS = 30;

/**
* Persist the user benefits response to cookies
*
Expand All @@ -48,16 +51,45 @@ const requestNewData = async () => {
*/
const persistResponse = (userBenefitsResponse: UserBenefits) => {
createOrRenewCookie(USER_BENEFITS_EXPIRY_COOKIE);

// All of these user benefits cookies are now valid for 30 days. Previously
// they were short lived (1-2 days) but this resulted in edge cases where if
// a signed in user didn't visit the site for more than a couple of days
// when they returned their first page view wouldn't reflect their benefits
// (i.e. they would see ads). This is due to a race condition between the
// user benefits refresh and the ads code. However, we don't want to delay
// ads until after the user benefits have been refreshed as that would
// impact performance. So instead, extend the expiry of the cookie. Note:
// this may result in a user getting benefits they no longer have on the
// first returning pageview, but this will be correct from the second page
// view onwards. We think this is OK. This also means we now remove cookies
// if the user benefits response says they no longer have the benefit,
// rather than simply letting the cookie expire.
if (userBenefitsResponse.hideSupportMessaging) {
createOrRenewCookie(HIDE_SUPPORT_MESSAGING_COOKIE);
createOrRenewCookie(
HIDE_SUPPORT_MESSAGING_COOKIE,
USER_BENEFITS_COOKIE_EXPIRATION_IN_DAYS,
);
} else {
removeCookie({ name: HIDE_SUPPORT_MESSAGING_COOKIE });
}

if (userBenefitsResponse.allowRejectAll) {
createOrRenewCookie(ALLOW_REJECT_ALL_COOKIE);
createOrRenewCookie(
ALLOW_REJECT_ALL_COOKIE,
USER_BENEFITS_COOKIE_EXPIRATION_IN_DAYS,
);
} else {
removeCookie({ name: ALLOW_REJECT_ALL_COOKIE });
}
// Ad free cookie has an expiry of 2 days from now
// See https://github.com/guardian/gateway/blob/52f810a88fa9ce23c6a794916251748718742c3d/src/server/lib/user-features.ts#L111-L115

if (userBenefitsResponse.adFree) {
createOrRenewCookie(AD_FREE_USER_COOKIE, 2);
createOrRenewCookie(
AD_FREE_USER_COOKIE,
USER_BENEFITS_COOKIE_EXPIRATION_IN_DAYS,
);
} else {
removeCookie({ name: AD_FREE_USER_COOKIE });
}
};

Expand Down
Loading