Refactor ab-testing fastly client #14884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakeii
force-pushed
the
jlk/ab-testing-fastly-client
branch
from
ad7bfd0 to
1aac145
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
on-ye
reviewed
Nov 25, 2025
arelra
reviewed
Nov 26, 2025
Comment on lines
+6
to
+16
| type MockedFetch = Mock<typeof fetch>; | ||
|
|
||
| function mockFetch(response: unknown, status = 200, statusText = "OK") { | ||
| const mockResponse = new Response(JSON.stringify(response), { | ||
| status, | ||
| statusText, | ||
| headers: { "Content-Type": "application/json" }, | ||
| }); | ||
|
|
||
| globalThis.fetch = mock.fn(async () => Promise.resolve(mockResponse)); | ||
| } |
Member
There was a problem hiding this comment.
Nice fetch mock you got there ✨
on-ye
approved these changes
Nov 26, 2025
Jakeii
added
run_chromatic
github-actions
bot
removed
the
run_chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #14882
What does this change?
Refactor the Fastly client to be a bit more ergonomic, using
client,serviceanddictionaryclasses. It's also been broken down into modules.Not much has changed, the functions have moved to class methods, and have added utility methods to get instances of child classes:
This is useful as the API url for dictionary operations needs the service id and version, which the
getDictionarymethod can set up.Why?
This came about as the currently client is coupled to
config.tswhich loads environment variables, with the class based client we can instantiate it with the API key and the consumer worries about how to get the API key.The (WIP) lambda that will be deploying the ab test config in the future will get the keys and service name/ids from parameter store and not environment variables.