Skip to content

Conversation

@BDisp
Copy link
Collaborator

@BDisp BDisp commented Dec 8, 2025

Fixes

  • Fixes #_____

Proposed Changes/Todos

  • [ x] Reversing the hierarchy of runnables so that the current runnable is the last to be drawn.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner December 8, 2025 12:03
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.40%. Comparing base (aab90e1) to head (a41afb2).

Files with missing lines Patch % Lines
Terminal.Gui/ViewBase/View.Drawing.cs 87.50% 0 Missing and 3 partials ⚠️
Terminal.Gui/ViewBase/View.NeedsDraw.cs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           v2_develop    #4465       +/-   ##
===============================================
- Coverage       77.48%   62.40%   -15.08%     
===============================================
  Files             386      386               
  Lines           44656    44671       +15     
  Branches         6280     6285        +5     
===============================================
- Hits            34601    27878     -6723     
- Misses           8208    14845     +6637     
- Partials         1847     1948      +101     
Files with missing lines Coverage Δ
Terminal.Gui/Drawing/Thickness.cs 96.15% <ø> (-2.31%) ⬇️
Terminal.Gui/ViewBase/View.NeedsDraw.cs 96.34% <75.00%> (-1.10%) ⬇️
Terminal.Gui/ViewBase/View.Drawing.cs 90.51% <87.50%> (+0.33%) ⬆️

... and 187 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aab90e1...a41afb2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BDisp
Copy link
Collaborator Author

BDisp commented Dec 8, 2025

This fix all the wide glyphs issue without breaks clipping.

VsDebugConsole_y3wp6QlDEv
VsDebugConsole_vFm6NsgNEE

@tig tig marked this pull request as draft December 9, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants