Update, migrate, improve log help links

Fix #10042
See also gwtproject/gwt-site#386

Author: vegegoku

build_tools/doctool/src/com/google/doctool/ResourceIncluder.java

@@ -40,23 +40,7 @@ private static String getFileFromClassPath(String partialPath)
       if (in == null) {
         throw new FileNotFoundException(partialPath);
       }
-      ByteArrayOutputStream os = new ByteArrayOutputStream();
-      byte[] buffer = new byte[1024];
-      int bytesRead;
-      while (true) {
-        bytesRead = in.read(buffer);
-        if (bytesRead >= 0) {
-          // Copy the bytes out.
-          os.write(buffer, 0, bytesRead);
-        } else {
-          // End of input stream.
-          break;
-        }
-      }
-
-      return os.toString(StandardCharsets.UTF_8);
-    } finally {
-      close(in);
+      return new String(in.readAllBytes(), StandardCharsets.UTF_8);
     }
   }
 

dev/core/src/com/google/gwt/dev/DevMode.java

@@ -31,7 +31,6 @@
 import com.google.gwt.dev.ui.RestartServerCallback;
 import com.google.gwt.dev.ui.RestartServerEvent;
 import com.google.gwt.dev.util.GwtprojectOrgHelpInfo;
-import com.google.gwt.dev.util.Util;
 import com.google.gwt.dev.util.arg.ArgHandlerDeployDir;
 import com.google.gwt.dev.util.arg.ArgHandlerExtraDir;
 import com.google.gwt.dev.util.arg.ArgHandlerFilterJsInteropExports;
@@ -732,7 +731,7 @@ private void validateServletTags(TreeLogger logger, ServletValidator servletVali
 
     TreeLogger servletLogger =
         logger.branch(TreeLogger.DEBUG, "Validating <servlet> tags for module '" + module.getName()
-            + "'", null, new GwtprojectOrgHelpInfo("/doc/latest/gwt-dev-help/servletMappings.html"));
+            + "'", null, new GwtprojectOrgHelpInfo("servletMappings.html"));
     for (String servletPath : servletPaths) {
       String servletClass = module.findServletForPath(servletPath);
       assert (servletClass != null);

dev/core/src/com/google/gwt/dev/javac/JSORestrictionsChecker.java

@@ -43,14 +43,14 @@
  * Check a compilation unit for violations of
  * {@link com.google.gwt.core.client.JavaScriptObject JavaScriptObject} (JSO)
  * restrictions. The restrictions are summarized in
- * @see <a href="https://www.gwtproject.org/doc/latest/DevGuideCodingBasicsJSNI.html">jsoRestrictions.html</a>.
+ * @see <a href="https://www.gwtproject.org/doc/latest/DevGuideCodingBasicsJSNI.html#important">Important Notes</a>.
  * Any violations found are attached as errors on the
  * CompilationUnitDeclaration.
  *
  * @see <a
  *      href="http://code.google.com/p/google-web-toolkit/wiki/OverlayTypes">Overlay
  *      types design doc</a>
- * @see <a href="https://www.gwtproject.org/doc/latest/DevGuideCodingBasicsJSNI.html">jsoRestrictions.html</a>
+ * @see <a href="https://www.gwtproject.org/doc/latest/DevGuideCodingBasicsJSNI.html#important">Important Notes</a>
  */
 public class JSORestrictionsChecker {
 

dev/core/src/com/google/gwt/dev/javac/JsniReferenceResolver.java

@@ -825,7 +825,7 @@ private boolean isUnsafeLongAnnotation(Annotation annot, ClassScope scope) {
 
   private void longAccessError(ASTNode node, String message) {
     GWTProblem.recordError(node, cud, message, new GwtprojectOrgHelpInfo(
-        "/doc/latest/gwt-dev-help/longJsniRestriction.html"));
+        "longJsniRestriction.html"));
   }
 
   private static void resolveJsniRef(JsniRef jsniRef, FieldBinding fieldBinding) {

dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java

@@ -20,7 +20,6 @@
 import com.google.gwt.core.ext.TreeLogger;
 import com.google.gwt.core.ext.UnableToCompleteException;
 import com.google.gwt.dev.util.GwtprojectOrgHelpInfo;
-import com.google.gwt.dev.util.Util;
 import com.google.gwt.thirdparty.guava.common.collect.Iterators;
 import com.google.gwt.thirdparty.guava.common.collect.Lists;
 
@@ -453,7 +452,7 @@ private boolean addContainingClassPathEntry(String warnMessage,
         }
         branch = branch.branch(logLevel, "Adding classpath entry '"
             + classPathURL + "' to the web app classpath for this session",
-            null, new GwtprojectOrgHelpInfo("/doc/latest/gwt-dev-help/webAppClassPath.html"));
+            null, new GwtprojectOrgHelpInfo("webAppClassPath.html"));
         try {
           addClassPath(classPathURL);
           return true;

dev/core/src/com/google/gwt/dev/util/GwtprojectOrgHelpInfo.java

@@ -28,7 +28,7 @@ public class GwtprojectOrgHelpInfo extends TreeLogger.HelpInfo {
 
   public GwtprojectOrgHelpInfo(String relativeUrl) {
     try {
-      url = new URL("https://gwtproject.org" + relativeUrl);
+      url = new URL("https://gwtproject.org/doc/latest/gwt-dev-help/" + relativeUrl);
     } catch (MalformedURLException ignored) {
       // ignore, url will be null
     }