implemenation of isna fexpr

Author: samukweku

src/core/expr/fexpr_isna.cc

@@ -60,4 +60,4 @@ DECLARE_PYFN(&pyfn_isna)
     ->n_required_args(1);
 
 
-}}  // dt::expr
+}}  // dt::expr

src/core/expr/fexpr_isna.h

@@ -0,0 +1,85 @@
+//------------------------------------------------------------------------------
+// Copyright 2022-2023 H2O.ai
+//
+// Permission is hereby granted, free of charge, to any person obtaining a
+// copy of this software and associated documentation files (the "Software"),
+// to deal in the Software without restriction, including without limitation
+// the rights to use, copy, modify, merge, publish, distribute, sublicense,
+// and/or sell copies of the Software, and to permit persons to whom the
+// Software is furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in
+// all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+// IN THE SOFTWARE.
+//------------------------------------------------------------------------------
+<<<<<<<< HEAD:src/core/expr/fexpr_isna.cc
+#include "column/const.h"
+#include "column/isna.h"
+#include "expr/fexpr_column.h"
+#include "documentation.h"
+#include "expr/fexpr_func_unary.h"
+#include "expr/eval_context.h"
+#include "expr/workframe.h"
+#include "python/xargs.h"
+#include "stype.h"
+========
+#ifndef dt_EXPR_FEXPR_ISNA_h
+#define dt_EXPR_FEXPR_ISNA_h
+#include "expr/fexpr_func.h"
+>>>>>>>> da5f26d3 (implemenation of isna fexpr):src/core/expr/fexpr_isna.h
+namespace dt {
+namespace expr {
+
+
+<<<<<<<< HEAD:src/core/expr/fexpr_isna.cc
+class FExpr_ISNA : public FExpr_FuncUnary {
+  public:
+    using FExpr_FuncUnary::FExpr_FuncUnary;
+
+
+    std::string name() const override {
+      return "isna";
+    }
+
+    Column evaluate1(Column&& col) const override{
+      return make_isna_col(std::move(col));
+    }
+};
+
+
+static py::oobj pyfn_isna(const py::XArgs &args) {
+  auto isna = args[0].to_oobj();
+  return PyFExpr::make(new FExpr_ISNA(as_fexpr(isna)));
+}
+
+DECLARE_PYFN(&pyfn_isna)
+    ->name("isna")
+    ->docs(doc_dt_isna)
+    ->arg_names({"cols"})
+    ->n_positional_args(1)
+    ->n_required_args(1);
+
+
+}}  // dt::expr
+========
+class FExpr_ISNA : public FExpr_Func {
+  private:
+    ptrExpr arg_;
+
+  public:
+    FExpr_ISNA(ptrExpr&& arg);
+    std::string repr() const override;
+    Workframe evaluate_n(EvalContext& ctx) const override;
+};
+
+
+}}  // dt::expr
+#endif
+>>>>>>>> da5f26d3 (implemenation of isna fexpr):src/core/expr/fexpr_isna.h

src/datatable/__init__.py

@@ -21,8 +21,8 @@
 # IN THE SOFTWARE.
 #-------------------------------------------------------------------------------
 from .frame import Frame
-from .expr import (min, max, sd, sum, count, countna, first, abs, exp,
-                   last, log, log10, f, g, median, cov, corr, nunique)
+from .expr import (min, max, sd, sum, count, first, abs, exp,
+                   last, log, log10, f, g, median, cov, corr, countna, nunique)
 from .lib._datatable import (
     as_type,
     by,
@@ -123,7 +123,6 @@
     "int8",
     "intersect",
     "iread",
-    "isna",
     "join",
     "last",
     "log",

src/datatable/expr/math.py

@@ -9,7 +9,7 @@
 #     http://www.apache.org/licenses/LICENSE-2.0
 #
 # Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
+# distributed undesrc = [False, True, False, False, True]r the License is distributed on an "AS IS" BASIS,
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.

src/datatable/math.py

@@ -48,7 +48,6 @@
     isclose,
     isfinite,
     isinf,
-    isna,
     ldexp,
     lgamma,
     log,

tests/math/test-isna.py

@@ -48,7 +48,7 @@
 @pytest.mark.parametrize("src", all_sources)
 def test_isna(src):
     DT = dt.Frame(src)
-    RES = DT[:, dt.isna(f[0])]
+    RES = DT[:, dt.math.isna(f[0])]
     assert_equals(RES, dt.Frame([(x is None) for x in src]))