Skip to content

Commit 78680ab

Browse files
committed
ODROID-COMMON: prevent to load device tree twice
Signed-off-by: Dongjin Kim <[email protected]> Change-Id: Ieb4a426ed0d229fec26e3c7844d65a6efe246df4
1 parent 73347d9 commit 78680ab

File tree

1 file changed

+13
-18
lines changed
  • board/hardkernel/odroid-common

1 file changed

+13
-18
lines changed

board/hardkernel/odroid-common/board.c

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -289,33 +289,25 @@ static int load_boot_config(struct blk_desc *dev_desc, char *config)
289289

290290
int board_read_dtb_file(void *fdt_addr)
291291
{
292+
char *paths[] = {
293+
"dtb",
294+
"rockchip/"CONFIG_ROCKCHIP_EARLY_DISTRO_DTB_PATH,
295+
};
292296
int ret;
293297

294298
ret = load_from_cramfs((unsigned long)fdt_addr, CONFIG_ROCKCHIP_EARLY_DISTRO_DTB_PATH);
295299
if (!ret) {
296300
if (panel)
297-
ret = dtoverlay_apply(fdt_addr, panel, NULL, NULL);
301+
dtoverlay_apply(fdt_addr, panel, NULL, NULL);
298302
} else {
299-
char *paths[] = {
300-
"dtb",
301-
"rockchip/"CONFIG_ROCKCHIP_EARLY_DISTRO_DTB_PATH,
302-
};
303303
struct blk_desc *dev_desc = rockchip_get_bootdev();
304-
int i;
305-
char buf[1024];
306304
char root[1024];
305+
char buf[1024];
306+
int i;
307307

308308
load_boot_config(dev_desc, "config.ini");
309309

310310
char *kvers = env_get("fk_kvers");
311-
if (!kvers) {
312-
/* Try to get kernel version from 'dtb' which must
313-
* be symbol link of device tree file in Linux
314-
*/
315-
load_from_mmc((unsigned long)fdt_addr, dev_desc->devnum, 1, "dtb");
316-
}
317-
318-
kvers = env_get("fk_kvers");
319311
if (kvers) {
320312
/* Set default device tree file with given kernel version */
321313
snprintf(root, sizeof(root), "dtbs/%s/rockchip/", kvers);
@@ -326,10 +318,13 @@ int board_read_dtb_file(void *fdt_addr)
326318
}
327319

328320
for (i = 0; i < ARRAY_SIZE(paths); i++) {
329-
ret = load_from_mmc((unsigned long)fdt_addr, dev_desc->devnum, 1, paths[i]);
321+
ret = load_from_mmc((unsigned long)fdt_addr,
322+
dev_desc->devnum, 1, paths[i]);
330323
if (!ret) {
331-
if (panel)
332-
ret = dtoverlay_apply(fdt_addr, panel, dev_desc, root);
324+
if (panel) {
325+
dtoverlay_apply(fdt_addr,
326+
panel, dev_desc, root);
327+
}
333328
break;
334329
}
335330
}

0 commit comments

Comments
 (0)