Skip to content

removing student from class should also remove them from specific non… #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lihelennn wants to merge 1 commit into
base: synchronous
Choose a base branch
from
Open

removing student from class should also remove them from specific non… #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions models/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,22 @@ module.exports = function(models){
removeStudent: function(classId, userId){
return Class.findByPk(classId, {include:[{association: 'GlobalSection'}]})
.then((nb_class) =>
User.findByPk(userId).then((user) =>
User.findByPk(userId).then((user) => {
nb_class.GlobalSection.removeMemberStudent(user)
)
// remove student from existing non-global section
Section.findOne({ where: {class_id: classId, is_global: false},
include: [{
model: models.User,
as: 'MemberStudents',
where: { id: userId }, // filter to find a section with this student
}]
})
.then(function (section) {
if (section) {
section.removeMemberStudent(user);
}
})
})
);
},
createAnnotation: function(location, head, instructors, sessionUserId) {
Expand Down