refactor: replace Split in loops with more efficient SplitSeq (#1561)

Signed-off-by: sunnyraindy <[email protected]>

Author: sunnyraindy

sdk/mnemonic.go

@@ -131,7 +131,7 @@ func (m Mnemonic) _Indices() ([]int, error) {
 	var check bool
 	temp := strings.Split(m.words, " ")
 	if len(temp) == 22 { // nolint
-		for _, mnemonicString := range strings.Split(m.words, " ") {
+		for mnemonicString := range strings.SplitSeq(m.words, " ") {
 			check = false
 			for i, stringCheck := range legacy {
 				if mnemonicString == stringCheck {
@@ -144,7 +144,7 @@ func (m Mnemonic) _Indices() ([]int, error) {
 			}
 		}
 	} else if len(temp) == 24 {
-		for _, mnemonicString := range strings.Split(m.words, " ") {
+		for mnemonicString := range strings.SplitSeq(m.words, " ") {
 			t, check := GetWordIndex(mnemonicString)
 			if !check {
 				return make([]int, 0), ErrInvalidMnemonic