Fallback to the default culture resource

[sivashkevych]

The default implementation of IStringLocalizer returns a string from the default culture resource if the localizer can't find the localization in the current resource.

However, the JsonStringLocalizer returns the localization string key value by default.

I've seen the PR Culture fallback to the rooted resource.
Are you going to merge it?

[hishamco]

Do you mean this PR #41?

[hishamco]

Seems the PR is too old, I can confirm that culture fallback is working

My.Extensions.Localization.Json/test/My.Extensions.Localization.Json.Tests/JsonStringLocalizerTests.cs

Lines 66 to 84 in 3dda94f

	[Theory]
	[InlineData("fr-FR", "Hello", "Bonjour")]
	[InlineData("fr-FR", "Hello, {0}", "Bonjour, {0}")]
	[InlineData("fr-FR", "Yes", "Oui")]
	[InlineData("fr-FR", "No", "No")]
	[InlineData("fr", "Hello", "Bonjour")]
	[InlineData("fr", "Yes", "Oui")]
	[InlineData("fr", "No", "No")]
	public void GetTranslationWithCultureFallback(string culture, string name, string expected)
	{
	// Arrange
	LocalizationHelper.SetCurrentCulture(culture);
	// Act
	string translation = _localizer[name];
	// Assert
	Assert.Equal(expected, translation);
	}

[sivashkevych]

Yes. I mean PR #41.

It seems that culture fallback isn't functioning correctly for the default culture.
In our project, we've included es.json and en-US.json, setting the default culture to "en-US".

Typically, with the standard IStringLocalizer, if a string isn't found in es.json, it falls back to en-US.json. However, with JsonStringLocalizer, it shows the string key instead.

I noticed in the previous PR that you implemented fallback to the default culture.
Merging PR #41 would enable us to have the same fallback behavior as with the original IStringLocalizer.

Thank you for considering this.

[hishamco]

Typically, with the standard IStringLocalizer, if a string isn't found in es.json, it falls back to en-US.json. However, with JsonStringLocalizer, it shows the string key instead.

Please show me the localization setup in your code

[sivashkevych]

Here is the localization setup:

builder.Services.AddJsonLocalization(options => options.ResourcesPath = "JsonResources");
builder.Services.Configure<RequestLocalizationOptions>(options =>
    {
        var supportedCultures = new[]
        {
            new CultureInfo("en-US"),
            new CultureInfo("es"),
        };
        options.DefaultRequestCulture = new RequestCulture("en-US");
        options.SupportedCultures = supportedCultures;
        options.SupportedUICultures = supportedCultures;
        options.ApplyCurrentCultureToResponseHeaders = true;
});

builder.Services.AddMvc()
    .AddViewLocalization()
    .AddDataAnnotationsLocalization();
    

[hishamco]

As I understand from you the fallback culture in the same culture set is working fine, but the fallback to the default culture is not working, right?

[sivashkevych]

Correct. Fallback from Spain to English (US) doesn't work.

[hishamco]

I will create a unit test, and then check

[sivashkevych]

I will create a unit test, and then check

Thank you, sir.

[hishamco]

Please check one case before I move further make sure that the requested resource is available in the default culture JSON file in your case en-US.json otherwise showing the resource name itself it make sense to me because it's not localized

[sivashkevych]

We have a "PagesHome" localized string in both en-US.json and es.json.

I removed it from es.json.
After that I can see PagesHome when I add ?culture=es to the URL
and Home when I add ?culture=en-US or by default without specifying culture.

[hishamco]

Let me double-check or write a functional test for this case

[sivashkevych]

Let me double-check or write a functional test for this case

Of course.

[hishamco]

@sivashkevych seems you confused with the culture fallback. If the culture is not exists in the supported culture then the fallback will be applied in your case if the culture is fr it SHOULD work, but if the localization find the resource on the supported culture it will show the same resource name if the value is not found

Hope it solved your problem

[hishamco]

Anything to add here @sivashkevych?