Skip to content

Conversation

@wlwatkins
Copy link


name: Pull Request
about: Create a pull request to help us improve
title: type annotation for raw texture to accept numpy
assignees: ''


Description:
As the doc says https://dearpygui.readthedocs.io/en/latest/documentation/textures.html#raw-textures , add_raw_texture should accept numpy.ndarray, but is it not in the default type hint, hence my ide is not happy. would this addition be agreable with you?

Concerning Areas:
Maybe there is other places, but this worked for me

As the doc says https://dearpygui.readthedocs.io/en/latest/documentation/textures.html#raw-textures , `add_raw_texture` should accept `numpy.ndarray`, but is it not in the default type hint, hence my ide is not happy. 
would this addition be agreable with you?
@wlwatkins wlwatkins requested a review from hoffstadt as a code owner March 21, 2023 22:15
@wlwatkins
Copy link
Author

hum... just realised numpy is not imported, and something tells me this is a big deal. i'm not sure if there's an alternative but to import it, at least using the type_check module

from typing import TYPE_CHECKING
if TYPE_CHECKING:
    import numpy as np

@melMass
Copy link

melMass commented Sep 24, 2024

+1 but this should be:

import numpy as np
import numpy.typing as npt

def add_raw_texture(
  ...
  default_value: Union[List[float], Tuple[float, ...], npt.NDArray[np.float32]]
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants