-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add Blueprint Editor #25646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add Blueprint Editor #25646
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
src/panels/config/blueprint/input/types/ha-blueprint-input-input.ts
Outdated
Show resolved
Hide resolved
|
yeesh! sorry gang, that took way longer than I expected. I suppose these things happen with open source development. Thanks again for your patience, this should be ready for review again. |
|
Things will move faster now that core is already approved, I'll give it a review this weekend. Feel free to resolve the linting issues in the meantime. |
|
Thanks for pointing that out, I totally missed the email telling me the lint failed! And I haven't been able to run it locally - I'm sure it's user error |
|
I totally missed the email that the lint was failing, so sorry about that! |
|
I've had a first test run on this, thank you for working on this.
We'll probably want to make it work the same as the automation editor (so the action and triggers pop up on the right), but we need to look into what changes are needed to make it work correctly. |
silamon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linting issues
src/panels/config/automation/condition/ha-automation-condition-editor.ts
Outdated
Show resolved
Hide resolved
| import "../ha-automation-editor-warning"; | ||
| import { editorStyles, indentStyle } from "../styles"; | ||
| import type { ConditionElement } from "./ha-automation-condition-row"; | ||
| import { consume } from "@lit/context"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Place this right after the other lit imports.
src/panels/config/automation/trigger/ha-automation-trigger-row.ts
Outdated
Show resolved
Hide resolved
src/panels/config/automation/trigger/ha-automation-trigger-row.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some fine tunings in the comments above. If you need help on some of the topics, don't hesitate to ask.
|
Thanks for the feedback! All good points. I'm hoping to address it soon |
…-editor.ts Co-authored-by: Simon Lamon <[email protected]>
Co-authored-by: Simon Lamon <[email protected]>
Co-authored-by: Simon Lamon <[email protected]>
Take your time. Beta cut is on wednesday, but it will probably be after that to merge since it's a big feature you're pulling in. |
- Make save button FAB - Make reset button part of blueprint card - Remove default values in new blueprint - UX/styling improvements
|
I believe I addressed everything! Let me know if there's something I missed. Regarding
The yaml is readonly - the intention is that this is just a place where you can generate the yaml to then copy to github (or other platforms), and seeing both at the same time is something I introduced when this page moved from the automations/scripts page to the blueprints page. I can implement a yaml/ui switch if that's preferred. |
Proposed change
I wanted to add an editor for Blueprints, similar to Automations and Scripts. Essentially, this creates a page that has an editor for
blueprintObject.metadata.input, then embeds the existing automation/script editor.There was a WTH forum post asking for this. I'm not sure if there were any formal feature requests/roadmap plans, but truthfully this is mostly inspired by my own desire for this feature to exist.
Type of change
Example configuration
I don't think any particular configuration is needed to test this, especially since HA comes with a couple blueprints out of the box.
Additional information
Additionally, I have concerns about the size of this MR. I think it's quite large. If it should be broken up, I'd love to do that. I just need guidance on the best strategy. However, there are parts of this feature I left out explicitly because of the size:
/showroute!inputs in visual selectorsSelector ConfigurationImplemented, thanks to feedback from karwosts!Checklist
testdirectory. Let me know if there's something I can look at!If user exposed functionality or configuration variables are added/changed: