Skip to content

Fix hide sidebar tooltip on touchend events #28042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MindFreeze merged 3 commits into from
Nov 27, 2025
Merged

Fix hide sidebar tooltip on touchend events #28042

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9ee0c8
fix: hide sidebar tooltip on touchend events
elchininet Nov 22, 2025
99b6ac1
Add a comment recommended by Copilot
elchininet Nov 24, 2025
1de7192
Clear timeouts id in disconnectedCallback
elchininet Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/components/ha-sidebar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,8 @@ class HaSidebar extends SubscribeMixin(LitElement) {

private _mouseLeaveTimeout?: number;

private _touchendTimeout?: number;

private _tooltipHideTimeout?: number;

private _recentKeydownActiveUntil = 0;
Expand Down Expand Up @@ -237,6 +239,18 @@ class HaSidebar extends SubscribeMixin(LitElement) {
];
}

public disconnectedCallback() {
super.disconnectedCallback();
// clear timeouts
clearTimeout(this._mouseLeaveTimeout);
clearTimeout(this._tooltipHideTimeout);
clearTimeout(this._touchendTimeout);
// set undefined values
this._mouseLeaveTimeout = undefined;
this._tooltipHideTimeout = undefined;
this._touchendTimeout = undefined;
}

protected render() {
if (!this.hass) {
return nothing;
Expand Down Expand Up @@ -406,6 +420,7 @@ class HaSidebar extends SubscribeMixin(LitElement) {
class="ha-scrollbar"
@focusin=${this._listboxFocusIn}
@focusout=${this._listboxFocusOut}
@touchend=${this._listboxTouchend}
@scroll=${this._listboxScroll}
@keydown=${this._listboxKeydown}
>
Expand Down Expand Up @@ -620,6 +635,14 @@ class HaSidebar extends SubscribeMixin(LitElement) {
this._hideTooltip();
}

private _listboxTouchend() {
clearTimeout(this._touchendTimeout);
this._touchendTimeout = window.setTimeout(() => {
// Allow 1 second for users to read the tooltip on touch devices
this._hideTooltip();
}, 1000);
}

@eventOptions({
passive: true,
})
Expand Down
Loading