Remove hard coded mqtt trigger, and migrate to new format #28143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendevlin
requested changes
Nov 26, 2025
Comment on lines
79
to
81
| if (!newValue.options) { | ||
| newValue.options = {}; | ||
| } |
Member
There was a problem hiding this comment.
I think this if is never true, it will be always created in the prev if (newValue === undefined)
Member
Author
There was a problem hiding this comment.
it is for typescript, it actually is always true
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
wendevlin
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Platform triggers only support config in
options, so we have to migrate the old style trigger configs to the new style when used as a platform trigger.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: