Skip to content

Proof of concept for account profiles. #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Proof of concept for account profiles. #158

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1a7a9b6
Proof of concept for account profiles.
jameswestnz Jun 2, 2016
5fca7ce
Merge branch 'master' into profile
jameswestnz Jun 14, 2016
cb223fa
restored options.includeProfile
jameswestnz Jun 14, 2016
940ff81
Removed profile fallback
jameswestnz Jun 14, 2016
b3f2a75
Allow profile update when updating account
jameswestnz Jun 15, 2016
b4d1f66
Fixed PATCH /session/account/profile
jameswestnz Jun 15, 2016
aa21170
Removed npmlog from account.js - was added for testing
jameswestnz Jun 15, 2016
e545911
Tests now pass
jameswestnz Jun 15, 2016
1a20c96
Reverted how the id was retrieved. HAd some inconsistent code which p…
jameswestnz Jun 15, 2016
95c58d2
And the tests to go with it
jameswestnz Jun 15, 2016
f69ffa9
Account add wasn't adding include to options, but instead properties.…
jameswestnz Jun 15, 2016
ed53fe9
Removed attributes modification in tests
jameswestnz Jun 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions tests/integration/routes/account/put-account-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,17 @@ getServer(function (error, server) {
}])

var options = _.defaultsDeep({
url: '/session/account?include=profile'
url: '/session/account?include=profile',
payload: {
data: {
attributes: {
profile: {
fullName: 'pat Doe',
email: '[email protected]'
}
}
}
}
Copy link
Member

@gr2m gr2m Jun 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}, routeOptions)

var accountWithProfileFixture = require('../../fixtures/account-with-profile.json')
Expand All @@ -98,10 +108,6 @@ getServer(function (error, server) {
response.result.data.id = 'userid123'
response.result.data.relationships.profile.data.id = 'userid123-profile'
response.result.included[0].id = 'userid123-profile'
response.result.included[0].attributes = {
fullName: 'pat Doe',
email: '[email protected]'
}
t.deepEqual(response.result, accountWithProfileFixture, 'returns account in right format')
t.end()
})
Expand Down