Skip to content

Conversation

@hwikle-lanl
Copy link
Collaborator

Code review checklist:

  • Code is generally sensical and well commented
  • Variable/function names all telegraph their purpose and contents
  • Functions/classes have useful doc strings
  • Function arguments are typed
  • Added/modified unit tests to cover changes.
  • New features have documentation added to the docs.
  • New features and backwards compatibility breaks are noted in the RELEASE.md

@hwikle-lanl hwikle-lanl self-assigned this Oct 30, 2025
@hwikle-lanl hwikle-lanl changed the title Catch NotADirectoryError from Path.touch Catch IsADirectoryError from Path.touch Oct 30, 2025
@hwikle-lanl
Copy link
Collaborator Author

Path.touch will raise an IsADirectoryError under certain circumstances, which I've verified PerfEng's working directory meets.

Paul-Ferrell
Paul-Ferrell previously approved these changes Oct 30, 2025
@hwikle-lanl hwikle-lanl force-pushed the hwikle/fix-perfeng-notadir branch from 2aa4a3e to 81c3851 Compare December 3, 2025 23:35
@smehta99 smehta99 self-requested a review December 4, 2025 19:07
Copy link
Collaborator

@smehta99 smehta99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hwikle-lanl hwikle-lanl merged commit 90ca062 into develop Dec 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants