improve error capture

Author: evalstate

packages/app/src/server/mcp-server.ts

@@ -157,7 +157,7 @@ export const createServerFactory = (_webServerInstance: WebServer, sharedApiClie
 			options?: QueryLoggerOptions
 		) => void;
 
-		type BaseQueryLoggerOptions = Omit<QueryLoggerOptions, 'durationMs' | 'success' | 'error'>;
+		type BaseQueryLoggerOptions = Omit<QueryLoggerOptions, 'durationMs' | 'error'>;
 
 		interface QueryLoggingConfig<T> {
 			methodName: string;
@@ -175,17 +175,24 @@ export const createServerFactory = (_webServerInstance: WebServer, sharedApiClie
 			const start = performance.now();
 			try {
 				const result = await work();
-				const durationMs = performance.now() - start;
+				const durationMs = Math.round(performance.now() - start);
 				const successOptions = config.successOptions?.(result) ?? {};
+				const { success: successOverride, ...restSuccessOptions } = successOptions;
+				const resultHasError =
+					typeof result === 'object' &&
+					result !== null &&
+					'isError' in result &&
+					Boolean((result as { isError?: boolean }).isError);
+				const successFlag = successOverride ?? !resultHasError;
 				logFn(config.methodName, config.query, config.parameters, {
 					...config.baseOptions,
-					...successOptions,
+					...restSuccessOptions,
 					durationMs,
-					success: true,
+					success: successFlag,
 				});
 				return result;
 			} catch (error) {
-				const durationMs = performance.now() - start;
+				const durationMs = Math.round(performance.now() - start);
 				logFn(config.methodName, config.query, config.parameters, {
 					...config.baseOptions,
 					durationMs,

packages/app/src/server/utils/query-logger.ts

@@ -208,6 +208,8 @@ export function logSearchQuery(
 ): void {
 	// Use a stable mcpServerSessionId per process/transport instance
 	const mcpServerSessionId = getMcpServerSessionId();
+	const normalizedDurationMs =
+		options?.durationMs !== undefined ? Math.round(options.durationMs) : undefined;
 	const serializedParameters = JSON.stringify(data);
 	const requestPayload = {
 		methodName,
@@ -230,7 +232,7 @@ export function logSearchQuery(
 		totalResults: options?.totalResults,
 		resultsShared: options?.resultsShared,
 		responseCharCount: options?.responseCharCount,
-		durationMs: options?.durationMs,
+		durationMs: normalizedDurationMs,
 		success: options?.success ?? true,
 		errorMessage: normalizedError,
 	});
@@ -247,6 +249,8 @@ export function logPromptQuery(
 ): void {
 	// Use a stable mcpServerSessionId per process/transport instance
 	const mcpServerSessionId = getMcpServerSessionId();
+	const normalizedDurationMs =
+		options?.durationMs !== undefined ? Math.round(options.durationMs) : undefined;
 	const serializedParameters = JSON.stringify(data);
 	const requestPayload = {
 		methodName,
@@ -269,7 +273,7 @@ export function logPromptQuery(
 		totalResults: options?.totalResults,
 		resultsShared: options?.resultsShared,
 		responseCharCount: options?.responseCharCount,
-		durationMs: options?.durationMs,
+		durationMs: normalizedDurationMs,
 		success: options?.success ?? true,
 		errorMessage: normalizedError,
 	});