Skip to content

Commit 2ed9da0

Browse files
committed
Restructure metrics table layout and consolidate errors
Changes: - Restored original first row layout (Active Connections/Request Count and Cleaned Sessions/Requests per Minute) - Moved Unique IPs to second row alongside consolidated errors - Combined Client/Server Errors into single "4xx/5xx" format (e.g., "123/45") - Applied consistent layout to both StatefulTransportMetrics and StatelessTransportMetrics This improves readability by grouping related metrics and reducing vertical space.
1 parent 5930fdf commit 2ed9da0

File tree

2 files changed

+16
-20
lines changed

2 files changed

+16
-20
lines changed

packages/app/src/web/components/StatefulTransportMetrics.tsx

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -255,15 +255,19 @@ export function StatefulTransportMetrics({ metrics }: StatefulTransportMetricsPr
255255
<TableRow>
256256
<TableCell className="font-medium text-sm">Total Connections</TableCell>
257257
<TableCell className="text-sm font-mono">{metrics.connections.total}</TableCell>
258-
<TableCell className="font-medium text-sm">Unique IPs</TableCell>
259-
<TableCell className="text-sm font-mono">{metrics.connections.uniqueIps ?? 0}</TableCell>
260-
</TableRow>
261-
<TableRow>
262258
<TableCell className="font-medium text-sm">Requests per Minute (tot/3hr/hr)</TableCell>
263-
<TableCell className="text-sm font-mono" colSpan={3}>
259+
<TableCell className="text-sm font-mono">
264260
{metrics.requests.averagePerMinute}/{metrics.requests.last3Hours}/{metrics.requests.lastHour}
265261
</TableCell>
266262
</TableRow>
263+
<TableRow>
264+
<TableCell className="font-medium text-sm">Unique IPs</TableCell>
265+
<TableCell className="text-sm font-mono">{metrics.connections.uniqueIps ?? 0}</TableCell>
266+
<TableCell className="font-medium text-sm">Client/Server Errors (4xx/5xx)</TableCell>
267+
<TableCell className="text-sm font-mono">
268+
{metrics.errors.expected}/{metrics.errors.unexpected}
269+
</TableCell>
270+
</TableRow>
267271
{metrics.sessionLifecycle && (
268272
<TableRow>
269273
<TableCell className="font-medium text-sm">Sessions New/Res-fail/Del</TableCell>
@@ -272,12 +276,6 @@ export function StatefulTransportMetrics({ metrics }: StatefulTransportMetricsPr
272276
</TableCell>
273277
</TableRow>
274278
)}
275-
<TableRow>
276-
<TableCell className="font-medium text-sm">Client Errors (4xx)</TableCell>
277-
<TableCell className="text-sm font-mono">{metrics.errors.expected}</TableCell>
278-
<TableCell className="font-medium text-sm">Server Errors (5xx)</TableCell>
279-
<TableCell className="text-sm font-mono">{metrics.errors.unexpected}</TableCell>
280-
</TableRow>
281279
{metrics.pings && (
282280
<TableRow>
283281
<TableCell className="font-medium text-sm">Pings Sent</TableCell>

packages/app/src/web/components/StatelessTransportMetrics.tsx

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -174,20 +174,18 @@ export function StatelessTransportMetrics({ metrics }: StatelessTransportMetrics
174174
<TableRow>
175175
<TableCell className="font-medium text-sm">Request Count (MCP)</TableCell>
176176
<TableCell className="text-sm font-mono">{metrics.connections.total}</TableCell>
177-
<TableCell className="font-medium text-sm">Unique IPs</TableCell>
178-
<TableCell className="text-sm font-mono">{metrics.connections.uniqueIps ?? 0}</TableCell>
179-
</TableRow>
180-
<TableRow>
181177
<TableCell className="font-medium text-sm">Requests per Minute (tot/3hr/hr)</TableCell>
182-
<TableCell className="text-sm font-mono" colSpan={3}>
178+
<TableCell className="text-sm font-mono">
183179
{metrics.requests.averagePerMinute}/{metrics.requests.last3Hours}/{metrics.requests.lastHour}
184180
</TableCell>
185181
</TableRow>
186182
<TableRow>
187-
<TableCell className="font-medium text-sm">Client Errors (4xx)</TableCell>
188-
<TableCell className="text-sm font-mono">{metrics.errors.expected}</TableCell>
189-
<TableCell className="font-medium text-sm">Server Errors (5xx)</TableCell>
190-
<TableCell className="text-sm font-mono">{metrics.errors.unexpected}</TableCell>
183+
<TableCell className="font-medium text-sm">Unique IPs</TableCell>
184+
<TableCell className="text-sm font-mono">{metrics.connections.uniqueIps ?? 0}</TableCell>
185+
<TableCell className="font-medium text-sm">Client/Server Errors (4xx/5xx)</TableCell>
186+
<TableCell className="text-sm font-mono">
187+
{metrics.errors.expected}/{metrics.errors.unexpected}
188+
</TableCell>
191189
</TableRow>
192190
{(metrics.staticPageHits200 !== undefined || metrics.staticPageHits405 !== undefined) && (
193191
<TableRow>

0 commit comments

Comments
 (0)