Fix dynamic_space tool INVOKE usage #115
Merged
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alse The dynamic_space tool with INVOKE operation requires direct_response=false to enable streaming/progress notifications. However, isGradioTool() wasn't recognizing 'dynamic_space' as a Gradio tool, causing directResponse to be incorrectly set to true. Changes: - Added DYNAMIC_SPACE_TOOL_CONFIG.name check to isGradioTool() - Updated function documentation and examples - Added test case for dynamic_space and gradio_files tools This ensures INVOKE operations on dynamic_space will properly use direct_response=false for streaming support.
gradio_files is a normal tool and doesn't need special streaming handling, so it should not be treated as a Gradio tool in isGradioTool(). Only dynamic_space and the gr<number>_/grp<number>_ pattern tools need direct_response=false for streaming support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.