Skip to content

Commit 06eb4dc

Browse files
committed
Update strings to not include .
1 parent 1283d30 commit 06eb4dc

File tree

6 files changed

+29
-29
lines changed

6 files changed

+29
-29
lines changed

Sources/Hummingbird/Application+ConfigReader.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ extension ApplicationConfiguration {
2323
/// - Configuration keys:
2424
/// - `host` (string, optional, default: "127.0.0.1"): Hostname or IP to bind server to
2525
/// - `port` (int, optional, default: 8080): Port to bind server to
26-
/// - `unix.domain.socket` (string, optional): Unix domain socket name
27-
/// - `server.name` (string, optional): Server name reported in HTTP headers
26+
/// - `unixDomainSocket` (string, optional): Unix domain socket name
27+
/// - `serverName` (string, optional): Server name reported in HTTP headers
2828
///
2929
/// - Parameters
3030
/// - reader: ConfigReader
@@ -33,10 +33,10 @@ extension ApplicationConfiguration {
3333
if let hostname = reader.string(forKey: "host") {
3434
let port = reader.int(forKey: "port", default: 8080)
3535
configuration.address = .hostname(hostname, port: port)
36-
} else if let unixDomainSocket = reader.string(forKey: "unix.domain.socket") {
36+
} else if let unixDomainSocket = reader.string(forKey: "unixDomainSocket") {
3737
configuration.address = .unixDomainSocket(path: unixDomainSocket)
3838
}
39-
if let serverName = reader.string(forKey: "server.name") {
39+
if let serverName = reader.string(forKey: "serverName") {
4040
configuration.serverName = serverName
4141
}
4242
self = configuration

Sources/HummingbirdCore/Server/HTTP/HTTP1Channel+ConfigReader.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@ extension HTTP1Channel.Configuration {
2121
/// Initialize a HTTP1Channel.Configuration from a ConfigReader
2222
///
2323
/// - Configuration keys
24-
/// - `idle.timeout` (double, optional): Time in seconds a connection can be left idle before closing
24+
/// - `idleTimeout` (double, optional): Time in seconds a connection can be left idle before closing
2525
///
2626
/// - Parameters
2727
/// - reader: ConfigReader
2828
public init(reader: ConfigReader) {
2929
var configuration = Self()
30-
if let idleTimeout = reader.double(forKey: "idle.timeout") {
30+
if let idleTimeout = reader.double(forKey: "idleTimeout") {
3131
configuration.idleTimeout = .nanoseconds(Int64(idleTimeout * 1_000_000_000))
3232
}
3333
self = configuration

Sources/HummingbirdHTTP2/HTTP2Channel+ConfigReader.swift

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,26 +22,26 @@ extension HTTP2Channel.Configuration {
2222
/// Initialize a HTTP2Channel.Configuration from a ConfigReader
2323
///
2424
/// - Configuration Keys
25-
/// - `h2.idle.timeout` (double optional): Time in seconds before an HTTP2 connection should be closed.
26-
/// - `h2.graceful.close.timeout` (double optional): Time in seconds to wait for client response after
25+
/// - `h2.idleTimeout` (double optional): Time in seconds before an HTTP2 connection should be closed.
26+
/// - `h2.gracefulCloseTimeout` (double optional): Time in seconds to wait for client response after
2727
/// all streams have been closed.
28-
/// - `h2.max.age.timeout` (double optional): Maximum time in seconds a connection can stay open.
28+
/// - `h2.maxAgeTimeout` (double optional): Maximum time in seconds a connection can stay open.
2929
/// - `h2.stream`: HTTP2 stream options. See ``HummingbirdCore/HTTP1Channel/Configuration/init(reader:)``
3030
///
3131
/// - Parameters
3232
/// - reader: ConfigReader
3333
public init(reader: ConfigReader) {
3434
var configuration = Self()
35-
if let idleTimeout = reader.double(forKey: "h2.idle.timeout") {
35+
if let idleTimeout = reader.double(forKey: "http2.idleTimeout") {
3636
configuration.idleTimeout = .seconds(idleTimeout)
3737
}
38-
if let gracefulCloseTimeout = reader.double(forKey: "h2.graceful.close.timeout") {
38+
if let gracefulCloseTimeout = reader.double(forKey: "http2.gracefulCloseTimeout") {
3939
configuration.gracefulCloseTimeout = .seconds(gracefulCloseTimeout)
4040
}
41-
if let maxAgeTimeout = reader.double(forKey: "h2.max.age.timeout") {
41+
if let maxAgeTimeout = reader.double(forKey: "http2.maxAgeTimeout") {
4242
configuration.maxAgeTimeout = .seconds(maxAgeTimeout)
4343
}
44-
let streamReader = reader.scoped(to: "h2.stream")
44+
let streamReader = reader.scoped(to: "http2.stream")
4545
configuration.streamConfiguration = HTTP1Channel.Configuration(reader: streamReader)
4646
self = configuration
4747
}

Sources/HummingbirdTLS/TLSChannel+ConfigReader.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,20 +32,20 @@ extension TLSChannelConfiguration {
3232
/// Initialize a TLSChannelConfiguration from a ConfigReader
3333
///
3434
/// - Configuration Keys
35-
/// - `tls.certificate.chain` (string, required): TLS certificate chain in PEM format
36-
/// - `tls.private.key` (string required): TLS private key in PEM format
37-
/// - `tls.trust.roots` (string optional): TLS trust roots in PEM format
35+
/// - `tls.certificateChain` (string, required): TLS certificate chain in PEM format
36+
/// - `tls.privateKey` (string required): TLS private key in PEM format
37+
/// - `tls.trustRoots` (string optional): TLS trust roots in PEM format
3838
///
3939
/// - Parameter reader: ConfigReader
4040
/// - Throws: TLSConfigError if "tls.certificate.chain" or "tls.private.key" values are missing
4141
public init(reader: ConfigReader) throws {
42-
guard let certificateChainPEM = reader.string(forKey: "tls.certificate.chain") else {
42+
guard let certificateChainPEM = reader.string(forKey: "tls.certificateChain") else {
4343
throw TLSConfigError.missingCertificateChain
4444
}
45-
guard let privateKeyPEM = reader.string(forKey: "tls.private.key") else {
45+
guard let privateKeyPEM = reader.string(forKey: "tls.privateKey") else {
4646
throw TLSConfigError.missingPrivateKey
4747
}
48-
let trustRootsPEM = reader.string(forKey: "tls.trust.roots")
48+
let trustRootsPEM = reader.string(forKey: "tls.trustRoots")
4949

5050
let certificateChain = try NIOSSLCertificate.fromPEMBytes([UInt8](certificateChainPEM.utf8))
5151
let privateKey = try NIOSSLPrivateKey(bytes: [UInt8](privateKeyPEM.utf8), format: .pem)

Tests/HummingbirdHTTP2Tests/ConfigReaderTests.swift

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ struct ConfigReaderTests {
2626
let configReader = ConfigReader(
2727
providers: [
2828
InMemoryProvider(values: [
29-
"tls.certificate.chain": .init(stringLiteral: serverCertificateData),
30-
"tls.private.key": .init(stringLiteral: serverPrivateKeyData),
31-
"tls.trust.roots": .init(stringLiteral: caCertificateData),
29+
"tls.certificateChain": .init(stringLiteral: serverCertificateData),
30+
"tls.privateKey": .init(stringLiteral: serverPrivateKeyData),
31+
"tls.trustRoots": .init(stringLiteral: caCertificateData),
3232
])
3333
]
3434
)
@@ -46,10 +46,10 @@ struct ConfigReaderTests {
4646
let configReader = ConfigReader(
4747
providers: [
4848
InMemoryProvider(values: [
49-
"h2.idle.timeout": 46.0,
50-
"h2.max.age.timeout": 500.5,
51-
"h2.graceful.close.timeout": 2.25,
52-
"h2.stream.idle.timeout": 15.0,
49+
"http2.idleTimeout": 46.0,
50+
"http2.maxAgeTimeout": 500.5,
51+
"http2.gracefulCloseTimeout": 2.25,
52+
"http2.stream.idleTimeout": 15.0,
5353
])
5454
]
5555
)

Tests/HummingbirdTests/ConfigReaderTests.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ struct ConfigReaderTests {
2929
InMemoryProvider(values: [
3030
"http.host": "0.0.0.0",
3131
"http.port": 12300,
32-
"http.server.name": "Test HB",
32+
"http.serverName": "Test HB",
3333
])
3434
]
3535
)
@@ -45,7 +45,7 @@ struct ConfigReaderTests {
4545
let configReader = ConfigReader(
4646
providers: [
4747
InMemoryProvider(values: [
48-
"http.unix.domain.socket": "/tmp/hb"
48+
"http.unixDomainSocket": "/tmp/hb"
4949
])
5050
]
5151
)
@@ -60,7 +60,7 @@ struct ConfigReaderTests {
6060
let configReader = ConfigReader(
6161
providers: [
6262
InMemoryProvider(values: [
63-
"idle.timeout": 65.0
63+
"idleTimeout": 65.0
6464
])
6565
]
6666
)

0 commit comments

Comments
 (0)