Skip to content

Commit 56a982b

Browse files
committed
Updated exception message to indicate both integer and numeric string expectations in all relevant data transformers and tests for improved clarity.
1 parent 2840c90 commit 56a982b

File tree

8 files changed

+8
-8
lines changed

8 files changed

+8
-8
lines changed

src/lib/Form/DataTransformer/ContentInfoTransformer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public function reverseTransform(mixed $value): ?ContentInfo
4646
}
4747

4848
if (!is_int($value) && !ctype_digit($value)) {
49-
throw new TransformationFailedException('Expected a numeric string.');
49+
throw new TransformationFailedException('Expected an integer or numeric string.');
5050
}
5151

5252
try {

src/lib/Form/DataTransformer/ContentTypeGroupTransformer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public function reverseTransform($value): ?ContentTypeGroup
4646
}
4747

4848
if (!is_int($value) && !ctype_digit($value)) {
49-
throw new TransformationFailedException('Expected a numeric string.');
49+
throw new TransformationFailedException('Expected an integer or numeric string.');
5050
}
5151

5252
try {

src/lib/Form/DataTransformer/RoleAssignmentTransformer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public function reverseTransform(mixed $value): ?APIRoleAssignment
5050
}
5151

5252
if (!is_int($value) && !ctype_digit($value)) {
53-
throw new TransformationFailedException('Expected a numeric string.');
53+
throw new TransformationFailedException('Expected an integer or numeric string.');
5454
}
5555

5656
try {

src/lib/Form/DataTransformer/RoleTransformer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function reverseTransform(mixed $value): ?APIRole
4949
}
5050

5151
if (!is_int($value) && !ctype_digit($value)) {
52-
throw new TransformationFailedException('Expected a numeric string.');
52+
throw new TransformationFailedException('Expected an integer or numeric string.');
5353
}
5454

5555
try {

tests/lib/Form/DataTransformer/ContentInfoTransformerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public function testReverseTransform(mixed $value, ?ContentInfo $expected): void
7676
public function testReverseTransformWithInvalidInput(mixed $value): void
7777
{
7878
$this->expectException(TransformationFailedException::class);
79-
$this->expectExceptionMessage('Expected a numeric string.');
79+
$this->expectExceptionMessage('Expected an integer or numeric string.');
8080

8181
$this->contentInfoTransformer->reverseTransform($value);
8282
}

tests/lib/Form/DataTransformer/ContentTypeGroupTransformerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ public function dataProviderForReverseTransformWithValidInput(): array
127127
public function testReverseTransformWithInvalidInput(mixed $value): void
128128
{
129129
$this->expectException(TransformationFailedException::class);
130-
$this->expectExceptionMessage('Expected a numeric string.');
130+
$this->expectExceptionMessage('Expected an integer or numeric string.');
131131

132132
$this->transformer->reverseTransform($value);
133133
}

tests/lib/Form/DataTransformer/RoleAssignmentTransformerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public function testReverseTransformWithInvalidInput(mixed $value): void
6969
$transformer = new RoleAssignmentTransformer($service);
7070

7171
$this->expectException(TransformationFailedException::class);
72-
$this->expectExceptionMessage('Expected a numeric string.');
72+
$this->expectExceptionMessage('Expected an integer or numeric string.');
7373

7474
$transformer->reverseTransform($value);
7575
}

tests/lib/Form/DataTransformer/RoleTransformerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public function testReverseTransformWithInvalidInput(mixed $value): void
6767
$transformer = new RoleTransformer($roleService);
6868

6969
$this->expectException(TransformationFailedException::class);
70-
$this->expectExceptionMessage('Expected a numeric string.');
70+
$this->expectExceptionMessage('Expected an integer or numeric string.');
7171

7272
$transformer->reverseTransform($value);
7373
}

0 commit comments

Comments
 (0)