Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a repro to show that using a large memtable on postgres gives an error. (at least I think this should repro, I am still having trouble getting postgres running in my env)
On my computer, this happens somewhere around 8400 rows, but is inconsistent, sometimes 8400 rows works, sometimes it errors. I'm getting this when connected to a hosted serverless neon.tech postgres instance.
I get a warning:
WARNING:psycopg:error ignored terminating <psycopg.Pipeline [BAD] at 0x3488be590>: the connection is lost, and then an error atibis/ibis/backends/postgres/__init__.py
Line 110 in 9431fa9
I can repo even more simply with
pgbackend._register_in_memory_tables(big_memtable), but I thought it would be good to only test the public APIPerhaps this is due to the
executemany()getting called too many times? Should we batch the memtable in smaller chunks?If you give me any pointers I can try to put up a fix, but I don't understand the root cause yet.