Change texts from "professor" to "instructor" #869
Description
as title states
This would make text consistent with how API structures their endpoints (their relevant endpoint is /v2/rest/instructors), and it is a more technically correct term, as some instructors have titles other than professor (Alex Thornton, for example, is a Lecturer, not a professor).
This would also make search results like the ones shown make more sense, as professors are a subset of instructors. (and other types of instructors, such as continuing lecturer, are not subsets of professors).
this would also involve changing routes from /professor/netid to /instructor/netid and setting up a redirect to improve consistency whilst not breaking existing links.