Skip to content

Commit 09a5e34

Browse files
committed
address review comments
1 parent e4a02fa commit 09a5e34

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

index.bs

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1238,16 +1238,19 @@ When this method is invoked, the user agent MUST run the following steps:
12381238
1. [=Populate the pose=] of |session|'s [=XRSession/viewer reference space=] in |referenceSpace| at the time represented by |frame| into |pose|, with `force emulation` set to `true`.
12391239
1. If |pose| is `null` return `null`.
12401240
1. Let |xrviews| be an empty [=/list=].
1241+
1. Let |offset| be `0`.
12411242
1. For each [=view/active=] [=view=] |view| in the [=XRSession/list of views=] on {{XRFrame/session}}, perform the following steps:
12421243
1. Let |xrview| be a new {{XRView}} object in the [=relevant realm=] of |session|.
12431244
1. Initialize |xrview|'s [=XRView/underlying view=] to |view|.
12441245
1. Initialize |xrview|'s {{XRView/eye}} to |view|'s [=view/eye=].
1246+
1. Initialize |xrview|'s {{XRView/index}} to |offset|.
12451247
1. Initialize |xrview|'s [=XRView/frame=] to |frame|.
12461248
1. Initialize |xrview|'s [=XRView/session=] to |session|.
12471249
1. Initialize |xrview|'s [=view/reference space=] to |referenceSpace|.
1248-
1. Let |offset| be an [=new=] {{XRRigidTransform}} object equal to the [=view offset=] of |view| in the [=relevant realm=] of |session|.
1249-
1. Set |xrview|'s {{XRViewGeometry/transform}} property to the result of [=multiply transforms|multiplying=] the {{XRViewerPose}}'s {{XRPose/transform}} by the |offset| transform in the relevant realm of |session|
1250-
1. [=list/Append=] |xrview| to |xrviews|
1250+
1. Let |viewtransform| be an [=new=] {{XRRigidTransform}} object equal to the [=view offset=] of |view| in the [=relevant realm=] of |session|.
1251+
1. Set |xrview|'s {{XRViewGeometry/transform}} property to the result of [=multiply transforms|multiplying=] the {{XRViewerPose}}'s {{XRPose/transform}} by the |viewtransform| transform in the relevant realm of |session|.
1252+
1. [=list/Append=] |xrview| to |xrviews|.
1253+
1. Increase |offset| by `1`.
12511254
1. Set |pose|'s {{XRViewerPose/views}} to |xrviews|
12521255
1. Return |pose|.
12531256

@@ -1587,7 +1590,7 @@ The {{XRViewGeometry/transform}} is given in it's [=view/reference space=].
15871590

15881591
The <dfn attribute for="XRView">eye</dfn> attribute describes the [=view/eye=] of the underlying [=view=]. This attribute's primary purpose is to ensure that pre-rendered stereo content can present the correct portion of the content to the correct eye.
15891592

1590-
The <dfn attribute for="XRView">index</dfn> attribute describes a unique offet of this {{XRView}}. This MUST be used by the experience to identify the {{XRView}} for each {{XREye}}.
1593+
The <dfn attribute for="XRView">index</dfn> attribute describes the offet of this {{XRView}} when it is return in the {{XRViewerPose/views}} array by {{XRFrame/getViewerPose()}}.
15911594

15921595
The optional <dfn attribute for="XRView">recommendedViewportScale</dfn> attribute contains a UA-recommended viewport scale value that the application can use for a {{XRView/requestViewportScale()}} call to configure dynamic viewport scaling. It is `null` if the system does not implement a heuristic or method for determining a recommended scale. If not null, the value MUST be a numeric value greater than 0.0 and less than or equal to 1.0, and MUST be [=quantization|quantized=] to avoid providing detailed performance or GPU utilization data.
15931596

@@ -2615,6 +2618,7 @@ interface XRVisibilityMaskChangeEvent : Event {
26152618
dictionary XRVisibilityMaskChangeEventInit : EventInit {
26162619
required XRSession session;
26172620
required XREye eye;
2621+
required unsigned long index;
26182622
required Float32Array vertices;
26192623
required Uint32Array indices;
26202624
};
@@ -2624,7 +2628,7 @@ The <dfn attribute for="XRVisibilityMaskChangeEvent">session</dfn> attribute ind
26242628

26252629
The <dfn attribute for="XRVisibilityMaskChangeEvent">eye</dfn> attribute indicates which {{XREye}} the mask applies to.
26262630

2627-
The <dfn attribute for="XRVisibilityMaskChangeEvent">index</dfn> attribute indicates which {{XRView/index}} the mask applies to.
2631+
The <dfn attribute for="XRVisibilityMaskChangeEvent">index</dfn> attribute indicates the offset into the [=XRSession/list of views=] of the {{XRView}} that this mask applies to.
26282632

26292633
The <dfn attribute for="XRVisibilityMaskChangeEvent">vertices</dfn> attribute is a [=/list=] of <code>X</code>, <code>Y</code> coordinates. The experience MUST assume that the <code>Z</code> coordinate is <code>-1</code>. Each <code>X</code>, <code>Y</code>, <code>Z</code> coordinate describes a vertex.
26302634
If this array is empty, the whole region of the {{XRView}} SHOULD be drawn.

0 commit comments

Comments
 (0)