chore(passport): ID-3373 upgrade Magic SDK @29.0.2 (#2597)

Author: naveen-imtb

packages/internal/toolkit/package.json

@@ -6,13 +6,13 @@
   "bugs": "https://github.com/immutable/ts-immutable-sdk/issues",
   "dependencies": {
     "@imtbl/x-client": "workspace:*",
-    "@magic-ext/oidc": "12.0.0",
+    "@magic-ext/oidc": "12.0.2",
     "@metamask/detect-provider": "^2.0.0",
     "axios": "^1.6.5",
     "bn.js": "^5.2.1",
     "enc-utils": "^3.0.0",
     "ethers": "^6.13.4",
-    "magic-sdk": "^29.0.0",
+    "magic-sdk": "^29.0.2",
     "oidc-client-ts": "2.4.0"
   },
   "devDependencies": {

packages/passport/sdk/package.json

@@ -13,15 +13,15 @@
     "@imtbl/toolkit": "workspace:*",
     "@imtbl/x-client": "workspace:*",
     "@imtbl/x-provider": "workspace:*",
-    "@magic-ext/oidc": "12.0.0",
-    "@magic-sdk/provider": "^29.0.0",
+    "@magic-ext/oidc": "12.0.2",
+    "@magic-sdk/provider": "^29.0.2",
     "@metamask/detect-provider": "^2.0.0",
     "axios": "^1.6.5",
     "ethers": "^6.13.4",
     "events": "^3.3.0",
     "jwt-decode": "^3.1.2",
     "localforage": "^1.10.0",
-    "magic-sdk": "^29.0.0",
+    "magic-sdk": "^29.0.2",
     "oidc-client-ts": "2.4.0",
     "uuid": "^8.3.2"
   },

packages/passport/sdk/src/magic/magicAdapter.test.ts

@@ -61,7 +61,7 @@ describe('MagicWallet', () => {
         jest.spyOn(window.document, 'readyState', 'get').mockReturnValue('complete');
         const magicAdapter = new MagicAdapter(config, magicProviderProxyFactory);
         // @ts-ignore
-        expect(magicAdapter.lazyMagicClient).toBeDefined();
+        expect(magicAdapter.magicClient).toBeDefined();
       });
     });
 

packages/passport/sdk/src/magic/magicAdapter.ts

@@ -4,7 +4,6 @@ import { Flow, trackDuration } from '@imtbl/metrics';
 import { Eip1193Provider } from 'ethers';
 import { PassportErrorType, withPassportError } from '../errors/passportError';
 import { PassportConfiguration } from '../config';
-import { lazyDocumentReady } from '../utils/lazyLoad';
 import { withMetricsAsync } from '../utils/metrics';
 import { MagicProviderProxyFactory } from './magicProviderProxyFactory';
 import { MagicClient } from './types';
@@ -16,29 +15,26 @@ export default class MagicAdapter {
 
   private readonly magicProviderProxyFactory: MagicProviderProxyFactory;
 
-  private readonly lazyMagicClient?: Promise<MagicClient>;
+  private readonly magicClient?: MagicClient;
 
   constructor(config: PassportConfiguration, magicProviderProxyFactory: MagicProviderProxyFactory) {
     this.config = config;
     this.magicProviderProxyFactory = magicProviderProxyFactory;
 
     if (typeof window !== 'undefined') {
-      this.lazyMagicClient = lazyDocumentReady<MagicClient>(() => {
-        const client = new Magic(this.config.magicPublishableApiKey, {
-          extensions: [new OpenIdExtension()],
-          network: MAINNET, // We always connect to mainnet to ensure addresses are the same across envs
-        });
-        return client;
+      this.magicClient = new Magic(this.config.magicPublishableApiKey, {
+        extensions: [new OpenIdExtension()],
+        network: MAINNET, // We always connect to mainnet to ensure addresses are the same across envs
       });
     }
   }
 
-  private get magicClient(): Promise<MagicClient> {
-    if (!this.lazyMagicClient) {
+  private getMagicClient(): MagicClient {
+    if (!this.magicClient) {
       throw new Error('Cannot perform this action outside of the browser');
     }
 
-    return this.lazyMagicClient;
+    return this.magicClient;
   }
 
   async login(
@@ -48,7 +44,7 @@ export default class MagicAdapter {
       withMetricsAsync(async (flow: Flow) => {
         const startTime = performance.now();
 
-        const magicClient = await this.magicClient;
+        const magicClient = this.getMagicClient();
         flow.addEvent('endMagicClientInit');
 
         await magicClient.openid.loginWithOIDC({
@@ -69,7 +65,7 @@ export default class MagicAdapter {
   }
 
   async logout() {
-    const magicClient = await this.magicClient;
+    const magicClient = this.getMagicClient();
     if (magicClient.user) {
       await magicClient.user.logout();
     }

packages/x-provider/package.json

@@ -9,12 +9,12 @@
     "@imtbl/generated-clients": "workspace:*",
     "@imtbl/toolkit": "workspace:*",
     "@imtbl/x-client": "workspace:*",
-    "@magic-ext/oidc": "12.0.0",
+    "@magic-ext/oidc": "12.0.2",
     "@metamask/detect-provider": "^2.0.0",
     "axios": "^1.6.5",
     "enc-utils": "^3.0.0",
     "ethers": "^6.13.4",
-    "magic-sdk": "^29.0.0",
+    "magic-sdk": "^29.0.2",
     "oidc-client-ts": "2.4.0"
   },
   "devDependencies": {