feat: step failed opcode

Author: Linell

go.mod

@@ -1,14 +1,14 @@
 module github.com/inngest/inngestgo
 
-go 1.24
+go 1.24.0
 
 require (
 	github.com/coder/websocket v1.8.12
 	github.com/fatih/structs v1.1.0
 	github.com/google/uuid v1.6.0
 	github.com/gosimple/slug v1.12.0
 	github.com/gowebpki/jcs v1.0.0
-	github.com/inngest/inngest v1.11.11-0.20250903154644-c3be9c4c8b45
+	github.com/inngest/inngest v1.11.14-0.20250926175522-7a60b676feb8
 	github.com/oklog/ulid/v2 v2.1.1
 	github.com/pbnjay/memory v0.0.0-20210728143218-7b4eea64cf58
 	github.com/sashabaranov/go-openai v1.35.6
@@ -29,7 +29,7 @@ require (
 	github.com/lmittmann/tint v1.1.0 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
 	golang.org/x/net v0.41.0 // indirect
-	golang.org/x/sys v0.33.0 // indirect
+	golang.org/x/sys v0.36.0 // indirect
 	golang.org/x/text v0.26.0 // indirect
 	google.golang.org/genproto/googleapis/rpc v0.0.0-20250603155806-513f23925822 // indirect
 	google.golang.org/grpc v1.73.0 // indirect

go.sum

@@ -34,8 +34,8 @@ github.com/hashicorp/errwrap v1.1.0 h1:OxrOeh75EUXMY8TBjag2fzXGZ40LB6IKw45YeGUDY
 github.com/hashicorp/errwrap v1.1.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
 github.com/hashicorp/go-multierror v1.1.1 h1:H5DkEtf6CXdFp0N0Em5UCwQpXMWke8IA0+lD48awMYo=
 github.com/hashicorp/go-multierror v1.1.1/go.mod h1:iw975J/qwKPdAO1clOe2L8331t/9/fmwbPZ6JB6eMoM=
-github.com/inngest/inngest v1.11.11-0.20250903154644-c3be9c4c8b45 h1:bk8rHGoa73umGpHKhIAFXgE7Bfh1pYv/6G8ZTv1FAxo=
-github.com/inngest/inngest v1.11.11-0.20250903154644-c3be9c4c8b45/go.mod h1:tt65lGtXioLxvpELpS1Y7/3ESrCaantUitJsqoQrVtM=
+github.com/inngest/inngest v1.11.14-0.20250926175522-7a60b676feb8 h1:z9l3Yk1nN6pDRmZjy2NQZ2jTV+jyHYOrs02+0kRxL6E=
+github.com/inngest/inngest v1.11.14-0.20250926175522-7a60b676feb8/go.mod h1:R5TKH7aKwziyiUOM7NxYqZxmsO78J/hCLT1frU5idzQ=
 github.com/kr/pretty v0.2.1/go.mod h1:ipq/a2n7PKx3OHsz4KJII5eveXtPO4qwEXGdVfWzfnI=
 github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
 github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk=
@@ -83,8 +83,8 @@ golang.org/x/net v0.41.0/go.mod h1:B/K4NNqkfmg07DQYrbwvSluqCJOOXwUjeb/5lOisjbA=
 golang.org/x/sync v0.15.0 h1:KWH3jNZsfyT6xfAfKiz6MRNmd46ByHDYaZ7KSkCtdW8=
 golang.org/x/sync v0.15.0/go.mod h1:1dzgHSNfp02xaA81J2MS99Qcpr2w7fw1gpm99rleRqA=
 golang.org/x/sys v0.0.0-20190626221950-04f50cda93cb/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
-golang.org/x/sys v0.33.0 h1:q3i8TbbEz+JRD9ywIRlyRAQbM0qF7hu24q3teo2hbuw=
-golang.org/x/sys v0.33.0/go.mod h1:BJP2sWEmIv4KK5OTEluFJCKSidICx8ciO85XgH3Ak8k=
+golang.org/x/sys v0.36.0 h1:KVRy2GtZBrk1cBYA7MKu5bEZFxQk4NIDV6RLVcC8o0k=
+golang.org/x/sys v0.36.0/go.mod h1:OgkHotnGiDImocRcuBABYBEXf8A9a87e/uXjp9XT3ks=
 golang.org/x/text v0.26.0 h1:P42AVeLghgTYr4+xUnTRKDMqpar+PtX7KWuNQL21L8M=
 golang.org/x/text v0.26.0/go.mod h1:QK15LZJUUQVJxhz7wXgxSy/CJaTFjd0G+YLonydOVQA=
 google.golang.org/genproto/googleapis/rpc v0.0.0-20250603155806-513f23925822 h1:fc6jSaCT0vBduLYZHYrBBNY4dsWuvgyff9noRNDdBeE=

handler.go

@@ -844,13 +844,19 @@ func (h *handler) invoke(w http.ResponseWriter, r *http.Request) error {
 	// For that reason, we check those values first.
 	noRetry := sdkerrors.IsNoRetryError(err)
 	retryAt := sdkerrors.GetRetryAtTime(err)
+
 	if len(ops) == 1 && ops[0].Op == enums.OpcodeStepError {
 		// Now we've handled error types we can ignore step
 		// errors safely.
 		err = nil
 	}
 
-	// Now that we've handled the OpcodeStepError, if we *still* ahve
+	// Handle OpcodeStepFailed for permanent step failures
+	if len(ops) == 1 && ops[0].Op == enums.OpcodeStepFailed {
+		noRetry = true
+	}
+
+	// Now that we've handled the OpcodeStepError, if we *still* have
 	// a StepError kind returned from a function we must have an unhandled
 	// step error.  This is a NonRetryableError, as the most likely code is:
 	//

internal/sdkrequest/request.go

@@ -29,6 +29,7 @@ type CallCtx struct {
 	StepID                    string    `json:"step_id"`
 	Stack                     CallStack `json:"stack"`
 	Attempt                   int       `json:"attempt"`
+	MaxAttempts               *int      `json:"max_attempts"`
 }
 
 type CallStack struct {

step/run.go

@@ -86,22 +86,32 @@ func Run[T any](
 	mutated := out.Result
 	err = out.Error
 	if err != nil {
-		// If tihs is a StepFailure already, fail fast.
+		// If this is a StepFailure already, fail fast.
 		if errors.IsStepError(err) {
 			mgr.SetErr(fmt.Errorf("unhandled step error: %s", err))
 			panic(sdkrequest.ControlHijack{})
 		}
 
+		isNoRetry := errors.IsNoRetryError(err)
+		maxAttemptsReached := shouldUseStepFailed(mgr)
+
 		marshalled, _ := json.Marshal(mutated)
 
-		// Implement per-step errors.
-		mgr.SetErr(err)
+		// Determine opcode based on retry eligibility
+		opcode := enums.OpcodeStepError
+		errorName := "Step error"
+
+		if isNoRetry || maxAttemptsReached {
+			opcode = enums.OpcodeStepFailed
+			errorName = "Step failed"
+		}
+
 		mgr.AppendOp(ctx, sdkrequest.GeneratorOpcode{
 			ID:   hashedID,
-			Op:   enums.OpcodeStepError,
+			Op:   opcode,
 			Name: id,
 			Error: &sdkrequest.UserError{
-				Name:    "Step failed",
+				Name:    errorName,
 				Message: err.Error(),
 				Data:    marshalled,
 			},
@@ -177,3 +187,12 @@ func loadExistingStep[T any](
 	val, _ := reflect.ValueOf(v).Elem().Interface().(T)
 	return val, nil
 }
+
+func shouldUseStepFailed(mgr sdkrequest.InvocationManager) bool {
+	callCtx := mgr.Request().CallCtx
+	if callCtx.MaxAttempts == nil {
+		return false
+	}
+
+	return callCtx.Attempt+1 >= *callCtx.MaxAttempts
+}