Skip to content

Commit 471a11e

Browse files
committed
runscripts for uncore freq
Signed-off-by: Harper, Jason M <[email protected]>
1 parent d4bcc62 commit 471a11e

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

cmd/config/set.go

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -324,19 +324,22 @@ func setUncoreDieFrequency(maxFreq bool, computeDie bool, uncoreFrequency float6
324324
bits = "15:21" // bits 15:21 are the min frequency
325325
}
326326
// run script for each die of specified type
327+
scripts = []script.ScriptDefinition{}
327328
for _, die := range dies {
328329
setScript := script.ScriptDefinition{
329-
Name: "write max and min uncore frequency TPMI",
330+
Name: fmt.Sprintf("write max and min uncore frequency TPMI %s %s", die.instance, die.entry),
330331
ScriptTemplate: fmt.Sprintf("pcm-tpmi 2 0x18 -d -b %s -w %d -i %s -e %s", bits, value, die.instance, die.entry),
331332
Vendors: []string{cpus.IntelVendor},
332333
Depends: []string{"pcm-tpmi"},
333334
Superuser: true,
335+
Sequential: true,
334336
}
335-
_, err = runScript(myTarget, setScript, localTempDir)
336-
if err != nil {
337-
err = fmt.Errorf("failed to set uncore die frequency: %w", err)
338-
break
339-
}
337+
scripts = append(scripts, setScript)
338+
}
339+
_, err = script.RunScripts(myTarget, scripts, false, localTempDir, nil, "")
340+
if err != nil {
341+
err = fmt.Errorf("failed to set uncore die frequency: %w", err)
342+
slog.Error(err.Error())
340343
}
341344
completeChannel <- setOutput{goRoutineID: goRoutineId, err: err}
342345
}

0 commit comments

Comments
 (0)