Skip to content

Commit cd5ed6d

Browse files
committed
fix: Add optional additional parameters for bridge creation
Fixes #31 Signed-off-by: Rafał Głombiowski [email protected]
1 parent ccf36e5 commit cd5ed6d

File tree

2 files changed

+8
-3
lines changed
  • mfd_network_adapter/network_adapter_owner/feature/ip
  • tests/unit/test_mfd_network_adapter/test_network_adapter_owner/test_feature/test_ip

2 files changed

+8
-3
lines changed

mfd_network_adapter/network_adapter_owner/feature/ip/linux.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,20 @@
1818
class LinuxIP(BaseIPFeature):
1919
"""Linux class for IP feature."""
2020

21-
def create_bridge(self, bridge_name: str, namespace: Optional[str] = None) -> None:
21+
def create_bridge(
22+
self, bridge_name: str, additional_parameters: Optional[str] = "", namespace: Optional[str] = None
23+
) -> None:
2224
"""
2325
Create bridge.
2426
2527
:param bridge_name: Bridge name.
28+
:param additional_parameters: Additional parameters for bridge creation.
2629
:param namespace: Name of network namespace
2730
"""
2831
self._connection.execute_command(
29-
add_namespace_call_command(f"ip link add name {bridge_name} type bridge", namespace=namespace)
32+
add_namespace_call_command(
33+
f"ip link add name {bridge_name} type bridge {additional_parameters}", namespace=namespace
34+
)
3035
)
3136

3237
def delete_bridge(self, bridge_name: str, namespace: Optional[str] = None) -> None:

tests/unit/test_mfd_network_adapter/test_network_adapter_owner/test_feature/test_ip/test_ip_linux.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def test_create_bridge(self, owner):
2424
)
2525
bridge_name = "br1"
2626
owner.ip.create_bridge(bridge_name)
27-
owner._connection.execute_command.assert_called_once_with(f"ip link add name {bridge_name} type bridge")
27+
owner._connection.execute_command.assert_called_once_with(f"ip link add name {bridge_name} type bridge ")
2828

2929
def test_delete_bridge(self, owner):
3030
owner._connection.execute_command.return_value = ConnectionCompletedProcess(

0 commit comments

Comments
 (0)