Skip to content

Commit 3375101

Browse files
authored
Add ellipsis while remove items (#515)
* Add ellipsis while remove items
1 parent fea7bef commit 3375101

File tree

12 files changed

+23
-78
lines changed

12 files changed

+23
-78
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"description": "The Internet Archive Collection Browser.",
44
"license": "AGPL-3.0-only",
55
"author": "Internet Archive",
6-
"version": "3.0.2",
6+
"version": "3.0.1",
77
"main": "dist/index.js",
88
"module": "dist/index.js",
99
"scripts": {
@@ -28,7 +28,7 @@
2828
"@internetarchive/field-parsers": "^1.0.0",
2929
"@internetarchive/histogram-date-range": "^1.4.0",
3030
"@internetarchive/ia-activity-indicator": "^0.0.6",
31-
"@internetarchive/ia-dropdown": "^1.4.1",
31+
"@internetarchive/ia-dropdown": "^1.4.0",
3232
"@internetarchive/iaux-item-metadata": "^1.0.5",
3333
"@internetarchive/infinite-scroller": "^1.0.1",
3434
"@internetarchive/modal-manager": "^2.0.1",

src/collection-browser.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2687,7 +2687,6 @@ export class CollectionBrowser
26872687
26882688
#tile-blur-check {
26892689
margin: 0 5px 0 0;
2690-
width: 15px;
26912690
}
26922691
26932692
circular-activity-indicator {

src/collection-facets.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,6 @@ export class CollectionFacets extends LitElement {
397397
? html`<button
398398
class="expand-date-picker-btn"
399399
aria-hidden="true"
400-
tabindex="-1"
401400
@click=${this.showDatePickerModal}
402401
>
403402
${expandIcon}
@@ -426,7 +425,7 @@ export class CollectionFacets extends LitElement {
426425

427426
return html`
428427
<histogram-date-range
429-
class=${this.isTvSearch ? 'wide-inputs' : ''}
428+
class=${this.isTvSearch ? 'wide-inputs' : nothing}
430429
.minDate=${minDate}
431430
.maxDate=${maxDate}
432431
.minSelectedDate=${this.minSelectedDate ?? minDate}
@@ -952,7 +951,6 @@ export class CollectionFacets extends LitElement {
952951
font-size: 1.2rem;
953952
text-decoration: none;
954953
padding: 0;
955-
margin-top: 0.25rem;
956954
background: inherit;
957955
border: 0;
958956
color: var(--ia-theme-link-color, #4b64ff);

src/collection-facets/facet-row.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,8 +213,7 @@ export class FacetRow extends LitElement {
213213
display: flex;
214214
font-weight: 500;
215215
font-size: 1.2rem;
216-
margin: 0 auto;
217-
padding: 0.25rem 0;
216+
margin: 2.5px auto;
218217
height: auto;
219218
border-top: ${facetRowBorderTop};
220219
border-bottom: ${facetRowBorderBottom};

src/manage/manage-bar.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ export class ManageBar extends LitElement {
6565
?disabled=${!this.removeAllowed}
6666
@click=${this.showRemoveItemsModal}
6767
>
68-
${msg('Remove selected items')} (${this.selectedItems.length})
68+
${msg('Remove selected items')} (${this.selectedItems.length})...
6969
</button>
7070
${when(
7171
this.showItemManageButton,

src/tiles/grid/collection-tile.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export class CollectionTile extends BaseTileComponent {
5555

5656
private get getTitleTemplate() {
5757
return html`<div id="title">
58-
<h3 class="truncated">${this.model?.title}</h3>
58+
<h4 class="truncated">${this.model?.title}</h4>
5959
</div>`;
6060
}
6161

@@ -123,8 +123,7 @@ export class CollectionTile extends BaseTileComponent {
123123
flex-grow: initial;
124124
}
125125
126-
h4.truncated,
127-
h3.truncated {
126+
h4.truncated {
128127
color: ${whiteColor};
129128
}
130129

src/tiles/grid/item-tile.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,9 @@ export class ItemTile extends BaseTileComponent {
6060
${this.imageBlockTemplate}
6161
6262
<div id="title">
63-
<h3 class="truncated" title=${ifDefined(itemTitle)}>
63+
<h4 class="truncated" title=${ifDefined(itemTitle)}>
6464
${itemTitle}
65-
</h3>
65+
</h4>
6666
</div>
6767
6868
${this.volumeIssueTemplate}

src/tiles/grid/search-tile.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export class SearchTile extends BaseTileComponent {
4949

5050
private get getTitleTemplate() {
5151
return html`<div id="title">
52-
<h3 class="truncated">${this.model?.title}</h3>
52+
<h4 class="truncated">${this.model?.title}</h4>
5353
</div>`;
5454
}
5555

@@ -70,8 +70,7 @@ export class SearchTile extends BaseTileComponent {
7070
flex-grow: initial;
7171
}
7272
73-
h4.truncated,
74-
h3.truncated {
73+
h4.truncated {
7574
color: ${whiteColor};
7675
-webkit-line-clamp: 4;
7776
}

src/tiles/grid/styles/tile-grid-shared-styles.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,7 @@ export const baseTileStyles = css`
7272
-webkit-box-orient: vertical;
7373
}
7474
75-
h4.truncated,
76-
h3.truncated {
75+
h4.truncated {
7776
display: -webkit-box;
7877
margin: 0px;
7978
line-height: 15px;
@@ -115,7 +114,7 @@ export const baseTileStyles = css`
115114
align-items: center;
116115
background: rgba(220, 220, 220, 0.5);
117116
color: white;
118-
font-size: 2.4rem;
117+
font-size: 2rem;
119118
font-weight: bold;
120119
line-height: 1;
121120
text-shadow: black 1px 1px 3px;

src/tiles/list/tile-list.ts

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { join } from 'lit/directives/join.js';
44
import { map } from 'lit/directives/map.js';
55
import { unsafeHTML } from 'lit/directives/unsafe-html.js';
66
import { customElement, property, state } from 'lit/decorators.js';
7-
import { msg, str } from '@lit/localize';
7+
import { msg } from '@lit/localize';
88
import DOMPurify from 'dompurify';
99

1010
import type { SortParam } from '@internetarchive/search-service';
@@ -94,11 +94,7 @@ export class TileList extends BaseTileComponent {
9494
isCollection,
9595
);
9696

97-
return html`<a
98-
id="image-link"
99-
title=${msg(str`View ${this.model?.title}`)}
100-
href=${href}
101-
>
97+
return html`<a href=${href}>
10298
<image-block
10399
.model=${this.model}
104100
.baseImageUrl=${this.baseImageUrl}
@@ -131,11 +127,7 @@ export class TileList extends BaseTileComponent {
131127
// Data templates
132128
private get iconRightTemplate() {
133129
return html`
134-
<a
135-
id="icon-right"
136-
href=${this.mediatypeURL}
137-
title=${msg(str`See more: ${this.model?.mediatype}`)}
138-
>
130+
<a id="icon-right" href=${this.mediatypeURL}>
139131
<tile-mediatype-icon .model=${this.model}> </tile-mediatype-icon>
140132
</a>
141133
`;

0 commit comments

Comments
 (0)