Add FAQ entry for changing the date format #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 13 13
Lines 396 396
=======================================
Hits 389 389
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rofinn
reviewed
Jul 16, 2021
|
|
||
| ```julia | ||
| # Changes the formatter of the console handler of the root logger | ||
| gethandlers(getlogger())["console"].fmt = DefaultFormatter("[{date} | {name} | {level}]: {msg}"; date_fmt_string="yyyy-mm-dd HH:MM:SS.sss") |
Member
There was a problem hiding this comment.
I don't think we actively want to support this approach, as it seems too easy to break. My recommendation would be to either refactor this package to support passing a dateformat kwarg to config! or explicitly mutate Memento._loggers["root"] = Logger(...) to reduce how much you're accessing private fields/components. At some point this package will require a refactor to make things less nested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I and at least one other person have needed this, I'm guessing it's common enough to have a FAQ entry.
Just not sure of the proposed solution, but this works for my case (changes the console handler for the root logger).
Should we suggest to the reader to do this for every handler they have? Unsure if/how the handlers & formatters get re-used in the logger hierarchy.