-
Notifications
You must be signed in to change notification settings - Fork 21
Open
Description
The app should go through various technical upgrades.
- we need to upgrade
react-searchkitto the latest, and therefore,axios. This is not easy, because the NodeJS version might have to be upgraded, leading to a certain number of tests failures. For now, we had to pincheerioto a specific version, and this should be removed at some point. - we should upgrade
NodeJS. However, this mean upgradingnpm, and the biggest change is that, by default, newer versions ofnpmthan the current v6 installpeerDepstoo. This cause issues. A workaround is to add the param--legacy-peer-depsto all npm command to simulate the previous behaviour. enzymeis completely abandoned. Anyway, in my opinion, snapshots testing did not turn out to be particularly useful. I propose to remove it entirely and tests too. For new test, we could use React Testing Library.
If it is to be kept, or you the error thatTextEncoderis not found, this commit should be added here too.- we could explore removing
craco, and come back to the defaultcreate react app. It was added becausecreate react appdoes not support LESS by default, and it is suggested by the React SemanticUI doc. Today, there could be better ways. If this is done, then we need to remove the aliases defined for webpack. - we should probably use the invenio linter rules.
- what about upgrading React?
- partial upgrades done in Upgrade npm #629
Metadata
Metadata
Assignees
Labels
No labels