feature: set ResponseEmitter encoding type #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to explicitly set the response emitter encoding type. This is used to set the encoding type of the response emitter to something other than the default. For example, when setting the encoding type to `Gzip` when compressed output is being emitted. Needed for: ipfs/kubo#2376
gammazero
commented
Dec 2, 2025
| }, | ||
| Gzip: func(req *Request) func(io.Writer) Encoder { | ||
| return func(w io.Writer) Encoder { return TextEncoder{w: w} } | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Mayme we should also add a Tar item here also?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to explicitly set the response emitter encoding type.
This is used to set the encoding type of the response emitter to something other than the default. For example, when setting the encoding type to
Gzipwhen compressed output is being emitted.Needed for: ipfs/kubo#2376
I do not know if this is the right way to do this, but testing with kubo PR above indicates it does work.
TODO: add unit test to check HTTP headers