sip: Manage active call list properly. #525
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the `sip_call_is_active` function is checking the active call list for the given call, it is preventing newly created calls from ever being added to the active list. Additionally, `vector_remove` returns silently when the given item is not present, so there is no reason to check if the call is in the active list before trying to remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the
sip_call_is_activefunction is checking the active call list for the given call, it is preventing newly created calls from ever being added to the active list.Additionally,
vector_removereturns silently when the given item is not present, so there is no reason to check if the call is in the active list before trying to remove it.