Fix define-syntax-parser-to-define-syntax-parse-rule-simple to only match syntax-wrapped bodies #772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
define-syntax-parser-to-define-syntax-parse-rule-simplerule was incorrectly matching and strippingsyntaxwrappers from all body forms, including cases where the body usedsyntax/loc, had no wrapper, or usedquasisyntax.Changes:
syntax(via[syntax-id syntax #:phase 1]literal)#:doblock that unconditionally stripped syntax wrappers from all forms[(_ . pattern) body ...]to[(_ . pattern) directive:syntax-parse-pattern-directive ... (syntax-id last-form)]Example:
Added test coverage for
syntax/loc, unwrapped bodies, andquasisyntaxcases.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.