Skip to content

Conversation

@redcapua
Copy link

@redcapua redcapua commented Dec 6, 2018

Fixing issue #45 :
Allow export/convert without header row
Some minor fix.

Allow export/convert without header row
Some minor fix.
@jakob
Copy link
Owner

jakob commented Dec 17, 2018

Thanks for the Pull request!

The export button should not change self.csvConfig.

But I think there is a bug in -dataWithCSVConfig:. It checks self.csvConfig, instead of using the passed parameter config when checking whether to write the headers. Then it should work.

PS: You've committed a lot of whitespace changes. In the future, please try to clean up your commits before submitting pull requests. (You can rewrite git commits from the command line, or you can use GitUp, it is a great GUI for cleaning up commits)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants