Skip to content

Conversation

@jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Dec 1, 2025

A first step toward running ty on the full codebase. I selected a few source files on which ty reveals just a handful of errors.

#jax-fixit

@jakevdp jakevdp self-assigned this Dec 1, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jakevdp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the ty type checker into the JAX continuous integration process, starting with the jax/_src/dtypes.py file. The primary goal is to enhance code quality and maintainability by proactively identifying type-related issues. The changes involve resolving initial type errors found by ty within the selected file and updating the project's build configuration to enable these checks.

Highlights

  • ty type checker integration: This PR introduces the ty type checker into the CI pipeline, specifically targeting the jax/_src/dtypes.py file. This is a foundational step towards broader type checking across the codebase to improve code quality.
  • Type annotation adjustments: Several type annotations in jax/_src/dtypes.py were updated to resolve issues identified by ty, including specifying builtins.type for a property and allowing None for the fun_name parameter in a function signature.
  • pyproject.toml configuration: The pyproject.toml file was updated to configure ty to specifically include jax/_src/dtypes.py for its initial type checking run.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/ci-build.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the ty type checker for jax/_src/dtypes.py and applies the necessary fixes for it to pass. The changes are correct and improve the type annotations in the file. I have one suggestion to refactor a piece of code to avoid a ty: ignore comment, which could improve clarity for the type checker. Overall, this is a great step towards better type safety in the codebase.

@jakevdp jakevdp changed the title Add CI to run ty on jax/_src/dtypes.py Add CI to run ty on a selection of JAX source files Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant